Bug 181392 - Layout Test imported/w3c/web-platform-tests/service-workers/service-worker/fetch-waits-for-activate.https.html is a flaky failure on macOS and iOS
Summary: Layout Test imported/w3c/web-platform-tests/service-workers/service-worker/fe...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-08 10:16 PST by Ryan Haddad
Modified: 2018-02-06 16:03 PST (History)
7 users (show)

See Also:


Attachments
Patch (10.69 KB, patch)
2018-02-06 12:46 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (10.74 KB, patch)
2018-02-06 13:37 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews106 for mac-sierra-wk2 (2.77 MB, application/zip)
2018-02-06 14:42 PST, EWS Watchlist
no flags Details
Patch (11.67 KB, patch)
2018-02-06 15:01 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (11.71 KB, patch)
2018-02-06 15:03 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2018-01-08 10:16:06 PST
The following layout test is flaky on on macOS and iOS

imported/w3c/web-platform-tests/service-workers/service-worker/fetch-waits-for-activate.https.html

Probable cause:

Unknown.

Flakiness Dashboard:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform-tests%2Fservice-workers%2Fservice-worker%2Ffetch-waits-for-activate.https.html

--- /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-waits-for-activate.https-expected.txt
+++ /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-waits-for-activate.https-actual.txt
@@ -1,3 +1,4 @@
 
-PASS Fetch events should wait for the activate event to complete. 
 
+FAIL Fetch events should wait for the activate event to complete. assert_unreached: unexpected rejection: assert_equals: active worker should be in activated state expected "activated" but got "activating" Reached unreachable code
+
Comment 1 Radar WebKit Bug Importer 2018-01-09 13:28:49 PST
<rdar://problem/36384136>
Comment 2 Matt Lewis 2018-01-10 13:54:56 PST
Marked as Flaky:
https://trac.webkit.org/changeset/226730/webkit
Comment 3 Chris Dumez 2018-02-06 12:01:39 PST
This looks very similar to Bug 181698.
Comment 4 Chris Dumez 2018-02-06 12:03:25 PST
(In reply to Chris Dumez from comment #3)
> This looks very similar to Bug 181698.

Unfortunately this fix went into r227070 and the flakiness dashboard still shows failures as of r228156.
Comment 5 Chris Dumez 2018-02-06 12:46:55 PST
Created attachment 333205 [details]
Patch
Comment 6 Chris Dumez 2018-02-06 13:37:00 PST
Created attachment 333208 [details]
Patch
Comment 7 EWS Watchlist 2018-02-06 14:42:10 PST
Comment on attachment 333208 [details]
Patch

Attachment 333208 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/6387666

New failing tests:
imported/w3c/web-platform-tests/service-workers/service-worker/fetch-response-taint.https.html
imported/w3c/web-platform-tests/service-workers/service-worker/fetch-csp.https.html
Comment 8 EWS Watchlist 2018-02-06 14:42:12 PST
Created attachment 333220 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 9 Chris Dumez 2018-02-06 15:01:35 PST
Created attachment 333224 [details]
Patch
Comment 10 Chris Dumez 2018-02-06 15:03:55 PST
Created attachment 333225 [details]
Patch
Comment 11 youenn fablet 2018-02-06 15:39:25 PST
Comment on attachment 333225 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333225&action=review

> Source/WebKit/ChangeLog:15
> +        the ServiceWorkerClientFetch callbacks schedule tasks to the runloop too.

Let's try to remove these callOnMainThread in the future.
For now, it is good to be consistent.
Comment 12 WebKit Commit Bot 2018-02-06 16:03:10 PST
Comment on attachment 333225 [details]
Patch

Clearing flags on attachment: 333225

Committed r228198: <https://trac.webkit.org/changeset/228198>
Comment 13 WebKit Commit Bot 2018-02-06 16:03:12 PST
All reviewed patches have been landed.  Closing bug.