Bug 181392 – Layout Test imported/w3c/web-platform-tests/service-workers/service-worker/fetch-waits-for-activate.https.html is a flaky failure on macOS and iOS

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Ryan Haddad]

The following layout test is flaky on on macOS and iOS

imported/w3c/web-platform-tests/service-workers/service-worker/fetch-waits-for-activate.https.html

Probable cause:

Unknown.

Flakiness Dashboard:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform-tests%2Fservice-workers%2Fservice-worker%2Ffetch-waits-for-activate.https.html

--- /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-waits-for-activate.https-expected.txt
+++ /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-waits-for-activate.https-actual.txt
@@ -1,3 +1,4 @@
 
-PASS Fetch events should wait for the activate event to complete. 
 
+FAIL Fetch events should wait for the activate event to complete. assert_unreached: unexpected rejection: assert_equals: active worker should be in activated state expected "activated" but got "activating" Reached unreachable code
+

[Radar WebKit Bug Importer]

<rdar://problem/36384136>

[Matt Lewis]

Marked as Flaky:
https://trac.webkit.org/changeset/226730/webkit

[Chris Dumez]

This looks very similar to Bug 181698.

[Chris Dumez]

(In reply to Chris Dumez from comment #3)
> This looks very similar to Bug 181698.

Unfortunately this fix went into r227070 and the flakiness dashboard still shows failures as of r228156.

[Chris Dumez]

Created attachment 333205 [details]
Patch

[Chris Dumez]

Created attachment 333208 [details]
Patch

[EWS Watchlist]

Comment on attachment 333208 [details]
Patch

Attachment 333208 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/6387666

New failing tests:
imported/w3c/web-platform-tests/service-workers/service-worker/fetch-response-taint.https.html
imported/w3c/web-platform-tests/service-workers/service-worker/fetch-csp.https.html

[EWS Watchlist]

Created attachment 333220 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[Chris Dumez]

Created attachment 333224 [details]
Patch

[Chris Dumez]

Created attachment 333225 [details]
Patch

[youenn fablet]

Comment on attachment 333225 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=333225&action=review

> Source/WebKit/ChangeLog:15
> +        the ServiceWorkerClientFetch callbacks schedule tasks to the runloop too.

Let's try to remove these callOnMainThread in the future.
For now, it is good to be consistent.

[WebKit Commit Bot]

Comment on attachment 333225 [details]
Patch

Clearing flags on attachment: 333225

Committed r228198: <https://trac.webkit.org/changeset/228198>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.