Bug 181387 - [FreeType] Use FastMalloc for FreeType
Summary: [FreeType] Use FastMalloc for FreeType
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-08 05:15 PST by Yusuke Suzuki
Modified: 2018-01-09 08:25 PST (History)
5 users (show)

See Also:

Attachments
Patch (2.47 KB, patch)
2018-01-08 05:16 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (2.47 KB, patch)
2018-01-08 05:18 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (2.61 KB, patch)
2018-01-08 06:04 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (2.77 KB, patch)
2018-01-09 07:44 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (2.77 KB, patch)
2018-01-09 07:56 PST, Yusuke Suzuki 		mcatanzaro: review+
Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2018-01-08 05:15:03 PST 
[FreeType] Use FastMalloc for FreeType
Comment 1 Yusuke Suzuki 2018-01-08 05:16:01 PST 
Created attachment 330689 [details]
Patch
Comment 2 EWS Watchlist 2018-01-08 05:16:54 PST 
Attachment 330689 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Yusuke Suzuki 2018-01-08 05:18:56 PST 
Created attachment 330691 [details]
Patch
Comment 4 Yusuke Suzuki 2018-01-08 06:04:03 PST 
Created attachment 330697 [details]
Patch
Comment 5 Yusuke Suzuki 2018-01-09 07:44:10 PST 
Created attachment 330823 [details]
Patch
Comment 6 Yusuke Suzuki 2018-01-09 07:56:20 PST 
Created attachment 330824 [details]
Patch
Comment 7 Michael Catanzaro 2018-01-09 08:16:38 PST 
Comment on attachment 330824 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330824&action=review

> Source/WebCore/platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp:81
> +        UNUSED_PARAM(currentSize);

Better style would be to just not name the parameter IMO. You already left links to the documentation, so people can look it up if they want to know what it is.
Comment 8 Yusuke Suzuki 2018-01-09 08:19:45 PST 
Comment on attachment 330824 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330824&action=review

Thanks!

>> Source/WebCore/platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp:81
>> +        UNUSED_PARAM(currentSize);
> 
> Better style would be to just not name the parameter IMO. You already left links to the documentation, so people can look it up if they want to know what it is.

OK, dropped this name.
Comment 9 Yusuke Suzuki 2018-01-09 08:24:00 PST 
Committed r226635: <https://trac.webkit.org/changeset/226635>
Comment 10 Radar WebKit Bug Importer 2018-01-09 08:25:06 PST 
<rdar://problem/36376027>