Bug 181385 – Add CSP support to service workers

• Status: RESOLVED
• Resolution: FIXED
• Component: Service Workers

[youenn fablet]

Add CSP support to service workers

[youenn fablet]

Created attachment 330681 [details]
Patch

[EWS Watchlist]

Attachment 330681 [details] did not pass style-queue:


ERROR: Source/WebCore/workers/service/context/ServiceWorkerThread.cpp:74:  Missing spaces around :  [whitespace/init] [4]
Total errors found: 1 in 25 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[youenn fablet]

rdar://problem/36164094

[youenn fablet]

Comment on attachment 330681 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330681&action=review

> Source/WebCore/workers/WorkerScriptLoader.h:29
> +#include "ContentSecurityPolicyResponseHeaders.h"

Include might not be needed in fact, will check this in a future iteration.

[Chris Dumez]

Comment on attachment 330681 [details]
Patch

Darn, I had the same patch locally that I did before the break.

[youenn fablet]

Thanks for the review.

(In reply to Chris Dumez from comment #5)
> Comment on attachment 330681 [details]
> Patch
> 
> Darn, I had the same patch locally that I did before the break.

We 'll call it the double-bullet-proof patch!

[youenn fablet]

Comment on attachment 330681 [details]
Patch

Not sure it will land without rebasing, but let's try

[WebKit Commit Bot]

Comment on attachment 330681 [details]
Patch

Rejecting attachment 330681 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 330681, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
ervice-workers/service-worker/service-worker-csp-connect.https-expected.txt
patching file LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/service-worker-csp-default.https-expected.txt
patching file LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/service-worker-csp-script.https-expected.txt

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Chris Dumez']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/5975033

[youenn fablet]

Created attachment 330725 [details]
Patch for landing

[EWS Watchlist]

Attachment 330725 [details] did not pass style-queue:


ERROR: Source/WebCore/workers/service/context/ServiceWorkerThread.cpp:74:  Missing spaces around :  [whitespace/init] [4]
Total errors found: 1 in 25 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 330725 [details]
Patch for landing

Clearing flags on attachment: 330725

Committed r226532: <https://trac.webkit.org/changeset/226532>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Commit Bot]

Re-opened since this is blocked by bug 181422

[youenn fablet]

Created attachment 330814 [details]
Patch for landing

[youenn fablet]

(In reply to youenn fablet from comment #14)
> Created attachment 330814 [details]
> Patch for landing

Relanding without modifying the SQL database, hence no CSP data persistency support.

[EWS Watchlist]

Attachment 330814 [details] did not pass style-queue:


ERROR: Source/WebCore/workers/service/context/ServiceWorkerThread.cpp:74:  Missing spaces around :  [whitespace/init] [4]
Total errors found: 1 in 24 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 330814 [details]
Patch for landing

Clearing flags on attachment: 330814

Committed r226628: <https://trac.webkit.org/changeset/226628>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.