RESOLVED FIXED 181384
WebProcessPool::terminateServiceWorkerProcess should protect itself in debug builds 
https://bugs.webkit.org/show_bug.cgi?id=181384
Summary WebProcessPool::terminateServiceWorkerProcess should protect itself in debug ...
youenn fablet
Reported 2018-01-08 04:04:52 PST
Otherwise, the assertions might do some use after free errors.
Attachments
Patch (1.37 KB, patch)
2018-01-08 04:06 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2018-01-08 04:06:25 PST
Created attachment 330680 [details] Patch
Radar WebKit Bug Importer
Comment 2 2018-01-08 05:24:53 PST
<rdar://problem/36347765>
Radar WebKit Bug Importer
Comment 3 2018-01-08 05:24:54 PST
<rdar://problem/36347764>
Chris Dumez
Comment 4 2018-01-08 10:22:23 PST
Comment on attachment 330680 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=330680&action=review > Source/WebKit/UIProcess/WebProcessPool.cpp:1461 > +#ifndef NDEBUG This looks suspicious. Why do we only need to protect |this| in debug?
youenn fablet
Comment 5 2018-01-08 10:25:26 PST
Comment on attachment 330680 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=330680&action=review >> Source/WebKit/UIProcess/WebProcessPool.cpp:1461 >> +#ifndef NDEBUG > > This looks suspicious. Why do we only need to protect |this| in debug? We only have ASSERT() after the call to requestTermination which may cause WebProcessPool to be freed.
WebKit Commit Bot
Comment 6 2018-01-08 10:37:41 PST
Comment on attachment 330680 [details] Patch Clearing flags on attachment: 330680 Committed r226519: <https://trac.webkit.org/changeset/226519>
WebKit Commit Bot
Comment 7 2018-01-08 10:37:42 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.