Bug 181384 - WebProcessPool::terminateServiceWorkerProcess should protect itself in debug builds
Summary: WebProcessPool::terminateServiceWorkerProcess should protect itself in debug ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-08 04:04 PST by youenn fablet
Modified: 2018-01-08 10:37 PST (History)
5 users (show)

See Also:


Attachments
Patch (1.37 KB, patch)
2018-01-08 04:06 PST, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2018-01-08 04:04:52 PST
Otherwise, the assertions might do some use after free errors.
Comment 1 youenn fablet 2018-01-08 04:06:25 PST
Created attachment 330680 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2018-01-08 05:24:53 PST
<rdar://problem/36347765>
Comment 3 Radar WebKit Bug Importer 2018-01-08 05:24:54 PST
<rdar://problem/36347764>
Comment 4 Chris Dumez 2018-01-08 10:22:23 PST
Comment on attachment 330680 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330680&action=review

> Source/WebKit/UIProcess/WebProcessPool.cpp:1461
> +#ifndef NDEBUG

This looks suspicious. Why do we only need to protect |this| in debug?
Comment 5 youenn fablet 2018-01-08 10:25:26 PST
Comment on attachment 330680 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330680&action=review

>> Source/WebKit/UIProcess/WebProcessPool.cpp:1461
>> +#ifndef NDEBUG
> 
> This looks suspicious. Why do we only need to protect |this| in debug?

We only have ASSERT() after the call to requestTermination which may cause WebProcessPool to be freed.
Comment 6 WebKit Commit Bot 2018-01-08 10:37:41 PST
Comment on attachment 330680 [details]
Patch

Clearing flags on attachment: 330680

Committed r226519: <https://trac.webkit.org/changeset/226519>
Comment 7 WebKit Commit Bot 2018-01-08 10:37:42 PST
All reviewed patches have been landed.  Closing bug.