Bug 181380 - [Cairo] Contain shadow blur requirement state in a separate object
Summary: [Cairo] Contain shadow blur requirement state in a separate object
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-08 03:16 PST by Zan Dobersek
Modified: 2018-01-08 06:39 PST (History)
6 users (show)

See Also:

Attachments
Patch (12.21 KB, patch)
2018-01-08 03:32 PST, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Patch for landing (12.21 KB, patch)
2018-01-08 06:35 PST, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2018-01-08 03:16:27 PST 
[Cairo] Contain shadow blur requirement state in a separate object
Comment 1 Zan Dobersek 2018-01-08 03:32:31 PST 
Created attachment 330675 [details]
Patch
Comment 2 Ms2ger (he/him; ⌚ UTC+1/+2) 2018-01-08 04:05:14 PST 
Comment on attachment 330675 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330675&action=review

> Source/WebCore/ChangeLog:12
> +        transform ingorance are stored there. Additionally, the required()

"ingorance"
Comment 3 Carlos Garcia Campos 2018-01-08 05:04:07 PST 
Comment on attachment 330675 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330675&action=review

> Source/WebCore/platform/graphics/cairo/CairoOperations.h:81
> +    ShadowBlurUsage() = default;

Why is this needed?

> Source/WebCore/platform/graphics/cairo/CairoOperations.h:88
> +    float shadowBlur;
> +    bool shadowsIgnoreTransforms;

These are uninitialized when the default ctor is used.
Comment 4 Zan Dobersek 2018-01-08 06:35:37 PST 
Created attachment 330700 [details]
Patch for landing

Addresses all the review comments
Comment 5 Zan Dobersek 2018-01-08 06:38:26 PST 
Comment on attachment 330700 [details]
Patch for landing

Clearing flags on attachment: 330700

Committed r226509: <https://trac.webkit.org/changeset/226509>
Comment 6 Zan Dobersek 2018-01-08 06:38:30 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-01-08 06:39:17 PST 
<rdar://problem/36348527>