Bug 181363 - Use WeakPtr for RenderTreePosition::m_nextSibling
Summary: Use WeakPtr for RenderTreePosition::m_nextSibling
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-06 04:05 PST by Antti Koivisto
Modified: 2018-01-06 13:02 PST (History)
5 users (show)

See Also:


Attachments
patch (2.57 KB, patch)
2018-01-06 04:09 PST, Antti Koivisto
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2018-01-06 04:05:02 PST
For safety.
Comment 1 Antti Koivisto 2018-01-06 04:09:38 PST
Created attachment 330637 [details]
patch
Comment 2 zalan 2018-01-06 08:14:17 PST
Comment on attachment 330637 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330637&action=review

> Source/WebCore/rendering/updating/RenderTreePosition.h:60
> +    WeakPtr<RenderObject> m_nextSibling { nullptr };

{ nullptr } is not really needed here.
Comment 3 WebKit Commit Bot 2018-01-06 13:01:23 PST
Comment on attachment 330637 [details]
patch

Clearing flags on attachment: 330637

Committed r226488: <https://trac.webkit.org/changeset/226488>
Comment 4 WebKit Commit Bot 2018-01-06 13:01:24 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-01-06 13:02:52 PST
<rdar://problem/36336120>