ssia
<rdar://problem/36328117>
Created attachment 330590 [details] Patch
Comment on attachment 330590 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=330590&action=review > Source/WebCore/rendering/RenderBlockFlow.cpp:3835 > void RenderBlockFlow::addChild(RenderTreeBuilder& builder, RenderPtr<RenderObject> newChild, RenderObject* beforeChild) > { > - if (multiColumnFlow() && (!isFieldset() || !newChild->isLegend())) > - return builder.insertChild(*multiColumnFlow(), WTFMove(newChild), beforeChild); > - auto* beforeChildOrPlaceholder = beforeChild; > - if (auto* containingFragmentedFlow = enclosingFragmentedFlow()) > - beforeChildOrPlaceholder = containingFragmentedFlow->resolveMovedChild(beforeChild); > - RenderBlock::addChild(builder, WTFMove(newChild), beforeChildOrPlaceholder); > + builder.insertChildToRenderBlockFlow(*this, WTFMove(newChild), beforeChild); > } Are there still some RenderBlockFlow subclasses with custom addChilds left? If not this could just move completely. > Source/WebCore/rendering/updating/RenderTreeBuilderBlockFlow.h:32 > +class RenderTreeBuilder::BlockFlow { Not sure how many of these we want. Could all Block stuff go to a single helper?
Created attachment 330716 [details] Patch
Comment on attachment 330716 [details] Patch Clearing flags on attachment: 330716 Committed r226537: <https://trac.webkit.org/changeset/226537>
All reviewed patches have been landed. Closing bug.