RESOLVED FIXED Bug 181347
Clean up Marquee-related enums 
https://bugs.webkit.org/show_bug.cgi?id=181347
Summary Clean up Marquee-related enums
Simon Fraser (smfr)
Reported 2018-01-05 14:35:17 PST
Clean up Marquee-related enums
Attachments
Patch (24.68 KB, patch)
2018-01-05 14:38 PST, Simon Fraser (smfr) 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2018-01-05 14:38:51 PST
Created attachment 330586 [details] Patch
Anders Carlsson
Comment 2 2018-01-06 09:58:30 PST
Fails on Windows: c:\cygwin\home\buildbot\webkit\source\webcore\rendering\rendermarquee.cpp(95): error C2220: warning treated as error - no 'object' file generated [C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj] c:\cygwin\home\buildbot\webkit\source\webcore\rendering\rendermarquee.cpp(95): warning C4715: 'WebCore::reverseDirection': not all control paths return a value [C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj]
Simon Fraser (smfr)
Comment 3 2018-01-16 08:51:31 PST
https://trac.webkit.org/changeset/226666/webkit
Radar WebKit Bug Importer
Comment 4 2018-01-16 08:52:37 PST
<rdar://problem/36545519>
Note You need to log in before you can comment on or make changes to this bug.