Bug 181347 - Clean up Marquee-related enums
Summary: Clean up Marquee-related enums
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-05 14:35 PST by Simon Fraser (smfr)
Modified: 2018-01-16 08:52 PST (History)
4 users (show)

See Also:

Attachments
Patch (24.68 KB, patch)
2018-01-05 14:38 PST, Simon Fraser (smfr) 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2018-01-05 14:35:17 PST 
Clean up Marquee-related enums
Comment 1 Simon Fraser (smfr) 2018-01-05 14:38:51 PST 
Created attachment 330586 [details]
Patch
Comment 2 Anders Carlsson 2018-01-06 09:58:30 PST 
Fails on Windows:

c:\cygwin\home\buildbot\webkit\source\webcore\rendering\rendermarquee.cpp(95): error C2220: warning treated as error - no 'object' file generated [C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj]
c:\cygwin\home\buildbot\webkit\source\webcore\rendering\rendermarquee.cpp(95): warning C4715: 'WebCore::reverseDirection': not all control paths return a value [C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj]
Comment 3 Simon Fraser (smfr) 2018-01-16 08:51:31 PST 
https://trac.webkit.org/changeset/226666/webkit
Comment 4 Radar WebKit Bug Importer 2018-01-16 08:52:37 PST 
<rdar://problem/36545519>