Currently there are a lot of PLATFORM checks around GraphicsContext that could be simplified and make it easier for out of trunk ports to build.
Created attachment 330589 [details] Patch
Attachment 330589 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 330718 [details] Patch
Comment on attachment 330718 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=330718&action=review Think this is ready for review. Just wondering if any of the platform checks can be simplified further. > Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:400 > +#if !PLATFORM(IOS) && !USE(OPENGL_ES_2) I'm not sure if this is correct for iOS or if it should just be if !USE(OPENGL_ES_2).
Comment on attachment 330718 [details] Patch Clearing flags on attachment: 330718 Committed r226581: <https://trac.webkit.org/changeset/226581>
All reviewed patches have been landed. Closing bug.
<rdar://problem/36361902>