Bug 181344 - Simplify platform checks in Graphics Context
Summary: Simplify platform checks in Graphics Context
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-05 14:11 PST by Don Olmstead
Modified: 2018-01-08 15:28 PST (History)
8 users (show)

See Also:


Attachments
Patch (4.17 KB, patch)
2018-01-05 14:58 PST, Don Olmstead
no flags Details | Formatted Diff | Diff
Patch (4.22 KB, patch)
2018-01-08 11:56 PST, Don Olmstead
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2018-01-05 14:11:15 PST
Currently there are a lot of PLATFORM checks around GraphicsContext that could be simplified and make it easier for out of trunk ports to build.
Comment 1 Don Olmstead 2018-01-05 14:58:30 PST
Created attachment 330589 [details]
Patch
Comment 2 EWS Watchlist 2018-01-05 14:59:24 PST
Attachment 330589 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Don Olmstead 2018-01-08 11:56:53 PST
Created attachment 330718 [details]
Patch
Comment 4 Don Olmstead 2018-01-08 11:58:54 PST
Comment on attachment 330718 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330718&action=review

Think this is ready for review. Just wondering if any of the platform checks can be simplified further.

> Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:400
> +#if !PLATFORM(IOS) && !USE(OPENGL_ES_2)

I'm not sure if this is correct for iOS or if it should just be if !USE(OPENGL_ES_2).
Comment 5 WebKit Commit Bot 2018-01-08 15:27:56 PST
Comment on attachment 330718 [details]
Patch

Clearing flags on attachment: 330718

Committed r226581: <https://trac.webkit.org/changeset/226581>
Comment 6 WebKit Commit Bot 2018-01-08 15:27:57 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-01-08 15:28:17 PST
<rdar://problem/36361902>