Bug 181324 - REGRESSION(r226306)[Win][CMake] Unnecessary recompilations triggered by unconditionally copied header files of DerivedSources
Summary: REGRESSION(r226306)[Win][CMake] Unnecessary recompilations triggered by uncon...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-05 02:36 PST by Fujii Hironori
Modified: 2018-01-05 03:12 PST (History)
6 users (show)

See Also:

Attachments
Patch (1.84 KB, patch)
2018-01-05 02:40 PST, Fujii Hironori 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2018-01-05 02:36:17 PST 
Bug 180921 changes to use cmake -E copy to copy header files of DerivedSources.
This command copies files unconditionally, then introduced unnecessary recompilations.
cmake -E copy_if_different should be used.
Comment 1 Fujii Hironori 2018-01-05 02:40:04 PST 
Created attachment 330543 [details]
Patch
Comment 2 WebKit Commit Bot 2018-01-05 03:11:47 PST 
Comment on attachment 330543 [details]
Patch

Clearing flags on attachment: 330543

Committed r226442: <https://trac.webkit.org/changeset/226442>
Comment 3 WebKit Commit Bot 2018-01-05 03:11:49 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2018-01-05 03:12:38 PST 
<rdar://problem/36316638>