RESOLVED FIXED Bug 181319
[RenderTreeBuilder] Move RenderBlock addChild logic to RenderTreeBuilder 
https://bugs.webkit.org/show_bug.cgi?id=181319
Summary [RenderTreeBuilder] Move RenderBlock addChild logic to RenderTreeBuilder
zalan
Reported 2018-01-04 21:57:26 PST
ssia.
Attachments
Patch (48.79 KB, patch)
2018-01-04 22:04 PST, zalan 		no flags
DetailsFormatted DiffDiff
Patch (48.83 KB, patch)
2018-01-04 22:07 PST, zalan 		no flags
DetailsFormatted DiffDiff
Patch (48.79 KB, patch)
2018-01-05 09:15 PST, zalan 		no flags
DetailsFormatted DiffDiff
Patch (48.82 KB, patch)
2018-01-08 09:08 PST, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-01-04 21:57:47 PST
<rdar://problem/36313464>
zalan
Comment 2 2018-01-04 22:04:05 PST
Created attachment 330531 [details] Patch
EWS Watchlist
Comment 3 2018-01-04 22:06:37 PST
Attachment 330531 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/updating/RenderTreeBuilderBlock.cpp:126: Multi line control clauses should use braces. [whitespace/braces] [4] Total errors found: 1 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
zalan
Comment 4 2018-01-04 22:07:33 PST
Created attachment 330532 [details] Patch
EWS Watchlist
Comment 5 2018-01-04 22:09:39 PST
Attachment 330532 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/updating/RenderTreeBuilderBlock.cpp:126: Multi line control clauses should use braces. [whitespace/braces] [4] Total errors found: 1 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
Antti Koivisto
Comment 6 2018-01-05 08:31:43 PST
Comment on attachment 330532 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=330532&action=review > Source/WebCore/rendering/RenderBlock.cpp:2980 > - makeChildrenNonInline(); > + RenderTreeBuilder::makeChildrenNonInline(*this); For consistency and future I think these should be non-static members of RenderTreeBuilder. You can use RenderTreeBuilder::current() to get the instance for now. > Source/WebCore/rendering/updating/RenderTreeBuilder.h:53 > + static void makeChildrenNonInline(RenderBlock& parent, RenderObject* insertionPoint = nullptr); > + static RenderObject* splitAnonymousBoxesAroundChild(RenderBox& parent, RenderObject* beforeChild); For consistency and future I think these should be non-static members of RenderTreeBuilder. You can use RenderTreeBuilder::current() to get the instance without having to pass it around.
zalan
Comment 7 2018-01-05 09:15:50 PST
Created attachment 330551 [details] Patch
EWS Watchlist
Comment 8 2018-01-05 09:18:10 PST
Attachment 330551 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/updating/RenderTreeBuilderBlock.cpp:126: Multi line control clauses should use braces. [whitespace/braces] [4] Total errors found: 1 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
zalan
Comment 9 2018-01-08 09:08:17 PST
Created attachment 330706 [details] Patch
EWS Watchlist
Comment 10 2018-01-08 09:10:26 PST
Attachment 330706 [details] did not pass style-queue: ERROR: Source/WebCore/rendering/updating/RenderTreeBuilderBlock.cpp:126: Multi line control clauses should use braces. [whitespace/braces] [4] Total errors found: 1 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 11 2018-01-08 09:40:24 PST
Comment on attachment 330706 [details] Patch Clearing flags on attachment: 330706 Committed r226516: <https://trac.webkit.org/changeset/226516>
WebKit Commit Bot
Comment 12 2018-01-08 09:40:26 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.