Bug 181296 - Add a new pattern matching rule to Graph::methodOfGettingAValueProfileFor for SetLocal(@nodeWithHeapPrediction)
Summary: Add a new pattern matching rule to Graph::methodOfGettingAValueProfileFor for...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-04 10:47 PST by Saam Barati
Modified: 2018-01-04 16:05 PST (History)
13 users (show)

See Also:


Attachments
patch (3.27 KB, patch)
2018-01-04 11:41 PST, Saam Barati
fpizlo: review+
Details | Formatted Diff | Diff
patch for landing (3.12 KB, patch)
2018-01-04 12:33 PST, Saam Barati
no flags Details | Formatted Diff | Diff
patch for landing (2.94 KB, patch)
2018-01-04 12:34 PST, Saam Barati
no flags Details | Formatted Diff | Diff
patch for landing (2.81 KB, patch)
2018-01-04 12:35 PST, Saam Barati
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2018-01-04 10:47:35 PST
Often they'll be from the same origin, so they don't fall into the normal loop that checks nodes from different origins. Speedometer has a lot of:

```
a:GetByVal(..., originX)
SetLocal(Cell:@a, locY, originX)
```

Where Cell:@a fails a lot. In such a case, it makes sense to update the value profile for the GetByVal.
Comment 1 Saam Barati 2018-01-04 11:41:14 PST
Created attachment 330476 [details]
patch
Comment 2 Saam Barati 2018-01-04 12:33:34 PST
Created attachment 330479 [details]
patch for landing

Made a slight change from the patch pizlo reviewed. Will wait for his thumbs up before landing.
Comment 3 Saam Barati 2018-01-04 12:34:36 PST
Created attachment 330480 [details]
patch for landing
Comment 4 Saam Barati 2018-01-04 12:35:19 PST
Created attachment 330481 [details]
patch for landing

Just fixing style stuff
Comment 5 Filip Pizlo 2018-01-04 15:34:59 PST
Comment on attachment 330481 [details]
patch for landing

still lgtm
Comment 6 WebKit Commit Bot 2018-01-04 16:01:37 PST
Comment on attachment 330481 [details]
patch for landing

Clearing flags on attachment: 330481

Committed r226426: <https://trac.webkit.org/changeset/226426>
Comment 7 WebKit Commit Bot 2018-01-04 16:01:38 PST
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2018-01-04 16:05:55 PST
<rdar://problem/36308599>