Bug 181295 - Add commas
Summary: Add commas
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Rollin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-04 10:39 PST by Keith Rollin
Modified: 2018-01-04 13:48 PST (History)
4 users (show)

See Also:

Attachments
Patch (3.08 KB, patch)
2018-01-04 12:26 PST, Keith Rollin 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 (2.80 MB, application/zip)
2018-01-04 13:30 PST, EWS Watchlist 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Rollin 2018-01-04 10:39:49 PST 
Fix a problem introduced in Bug 180883 where the emitted JSON didn't include some required commas.
Comment 1 Keith Rollin 2018-01-04 10:40:38 PST 
<rdar://problem/35802295>
Comment 2 Keith Rollin 2018-01-04 12:26:47 PST 
Created attachment 330478 [details]
Patch
Comment 3 Brent Fulgham 2018-01-04 12:45:44 PST 
Comment on attachment 330478 [details]
Patch

Commas are good. r=me.
Comment 4 EWS Watchlist 2018-01-04 13:21:09 PST 
Attachment 330478 [details] did not pass style-queue:


ERROR: Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:752:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:753:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:754:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:755:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp:761:  Missing space before {  [whitespace/braces] [5]
Total errors found: 5 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 EWS Watchlist 2018-01-04 13:30:35 PST 
Comment on attachment 330478 [details]
Patch

Attachment 330478 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/5928077

New failing tests:
fast/mediastream/MediaStream-MediaElement-setObject-null.html
Comment 6 EWS Watchlist 2018-01-04 13:30:37 PST 
Created attachment 330485 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 7 WebKit Commit Bot 2018-01-04 13:48:00 PST 
Comment on attachment 330478 [details]
Patch

Clearing flags on attachment: 330478

Committed r226419: <https://trac.webkit.org/changeset/226419>
Comment 8 WebKit Commit Bot 2018-01-04 13:48:02 PST 
All reviewed patches have been landed.  Closing bug.