Bug 181291 - [MediaStream] Add Mock screen capture source
Summary: [MediaStream] Add Mock screen capture source
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-04 08:46 PST by Eric Carlson
Modified: 2018-01-05 09:13 PST (History)
4 users (show)

See Also:

Attachments
Patch (87.81 KB, patch)
2018-01-04 10:41 PST, Eric Carlson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2018-01-04 08:46:12 PST 
Add Mock screen capture source
Comment 1 Radar WebKit Bug Importer 2018-01-04 08:46:37 PST 
<rdar://problem/36298164>
Comment 2 Eric Carlson 2018-01-04 10:41:16 PST 
Created attachment 330474 [details]
Patch
Comment 3 Dean Jackson 2018-01-04 11:48:31 PST 
Comment on attachment 330474 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330474&action=review

> Source/WebCore/platform/mediastream/mac/DisplayCaptureSourceCocoa.h:74
> +    double m_startTime { NAN };
> +    double m_elapsedTime { 0 };

Should you use Seconds here, rather than a double?
Comment 4 WebKit Commit Bot 2018-01-04 12:12:31 PST 
Comment on attachment 330474 [details]
Patch

Clearing flags on attachment: 330474

Committed r226412: <https://trac.webkit.org/changeset/226412>
Comment 5 WebKit Commit Bot 2018-01-04 12:12:33 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Eric Carlson 2018-01-04 14:31:52 PST 
Comment on attachment 330474 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330474&action=review

>> Source/WebCore/platform/mediastream/mac/DisplayCaptureSourceCocoa.h:74
>> +    double m_elapsedTime { 0 };
> 
> Should you use Seconds here, rather than a double?

Oops, I missed this suggestion. I will do this in an upcoming patch.
Comment 7 Chris Nardi 2018-01-04 22:04:09 PST 
This patch seems to have caused a GTK compile issue (see for instance https://webkit-queues.webkit.org/results/5936753).
Comment 8 Eric Carlson 2018-01-05 09:13:31 PST 
(In reply to Chris Nardi from comment #7)
> This patch seems to have caused a GTK compile issue (see for instance
> https://webkit-queues.webkit.org/results/5936753).

Oops, sorry about that! Thanks to Zan for fixing this in r226438.