Bug 181291 – [MediaStream] Add Mock screen capture source

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[Eric Carlson]

Add Mock screen capture source

[Radar WebKit Bug Importer]

<rdar://problem/36298164>

[Eric Carlson]

Created attachment 330474 [details]
Patch

[Dean Jackson]

Comment on attachment 330474 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330474&action=review

> Source/WebCore/platform/mediastream/mac/DisplayCaptureSourceCocoa.h:74
> +    double m_startTime { NAN };
> +    double m_elapsedTime { 0 };

Should you use Seconds here, rather than a double?

[WebKit Commit Bot]

Comment on attachment 330474 [details]
Patch

Clearing flags on attachment: 330474

Committed r226412: <https://trac.webkit.org/changeset/226412>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Eric Carlson]

Comment on attachment 330474 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330474&action=review

>> Source/WebCore/platform/mediastream/mac/DisplayCaptureSourceCocoa.h:74
>> +    double m_elapsedTime { 0 };
> 
> Should you use Seconds here, rather than a double?

Oops, I missed this suggestion. I will do this in an upcoming patch.

[Chris Nardi]

This patch seems to have caused a GTK compile issue (see for instance https://webkit-queues.webkit.org/results/5936753).

[Eric Carlson]

(In reply to Chris Nardi from comment #7)
> This patch seems to have caused a GTK compile issue (see for instance
> https://webkit-queues.webkit.org/results/5936753).

Oops, sorry about that! Thanks to Zan for fixing this in r226438.