Bug 181290 - WebContent process crashes while loading https://www.classicspecs.com
Summary: WebContent process crashes while loading https://www.classicspecs.com
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-04 08:33 PST by zalan
Modified: 2018-01-04 12:14 PST (History)
6 users (show)

See Also:

Attachments
Patch (4.61 KB, patch)
2018-01-04 09:30 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (4.61 KB, patch)
2018-01-04 09:47 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2018-01-04 08:33:33 PST 
rdar://problem/36225906
Comment 1 zalan 2018-01-04 09:30:52 PST 
Created attachment 330469 [details]
Patch
Comment 2 Brent Fulgham 2018-01-04 09:45:08 PST 
Comment on attachment 330469 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330469&action=review

The fix is so tiny compared to the explanation! I think this looks good, but I think Simon should have the final say.

> Source/WebCore/ChangeLog:11
> +        we need to deregister it from all those blocks. We do it by walking up on the ancestor block chain

"We do it by walking up the ancestor block chain" (no 'on')

> Source/WebCore/ChangeLog:12
> +        and check if parent (grandparent etc) block still contains this float. Once we find the topmost block, 

"and checking if the parent..."
Comment 3 zalan 2018-01-04 09:47:10 PST 
Created attachment 330472 [details]
Patch
Comment 4 WebKit Commit Bot 2018-01-04 12:14:57 PST 
Comment on attachment 330472 [details]
Patch

Clearing flags on attachment: 330472

Committed r226413: <https://trac.webkit.org/changeset/226413>
Comment 5 WebKit Commit Bot 2018-01-04 12:14:59 PST 
All reviewed patches have been landed.  Closing bug.