Bug 181287 – Implement createImageBitmap(ImageBitmap)

• Status: RESOLVED
• Resolution: FIXED
• Component: Canvas

[Ms2ger (he/him; ⌚ UTC+1/+2)]

.

[Ms2ger (he/him; ⌚ UTC+1/+2)]

Created attachment 330460 [details]
Patch

[Darin Adler]

Comment on attachment 330460 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330460&action=review

> Source/WebCore/html/ImageBitmap.cpp:399
> +    if (existingImageBitmap->isDetached() || !existingImageBitmap->buffer()) {

Why do we need both checks? Why isn’t isDetached sufficient? Do we have test cases covering both cases?

[WebKit Commit Bot]

Comment on attachment 330460 [details]
Patch

Clearing flags on attachment: 330460

Committed r226500: <https://trac.webkit.org/changeset/226500>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/36344128>

[Ms2ger (he/him; ⌚ UTC+1/+2)]

(In reply to Darin Adler from comment #2)
> Comment on attachment 330460 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=330460&action=review
> 
> > Source/WebCore/html/ImageBitmap.cpp:399
> > +    if (existingImageBitmap->isDetached() || !existingImageBitmap->buffer()) {
> 
> Why do we need both checks? Why isn’t isDetached sufficient? Do we have test
> cases covering both cases?

I followed the pattern in ImageBitmap::width/height(), which also check both. I think it'd be possible to simply define isDetached() as !buffer() at this point (removing the m_detached member), but I don't really want to do that until the implementation of the API is more complete. Will make a note to look into it later.