Bug 181285 – Use no-cache fetch mode when loading main documents with location.reload()

• Status: REOPENED
• Component: Service Workers

[youenn fablet]

Use no-cache fetch mode when loading main documents with location.reload()

[youenn fablet]

Created attachment 330458 [details]
Patch

[EWS Watchlist]

Comment on attachment 330458 [details]
Patch

Attachment 330458 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/5925417

New failing tests:
http/tests/navigation/statistics.html
http/tests/navigation/redirect-on-back-updates-history-item.html
http/tests/navigation/post-frames-goback1-uncached.html
http/tests/navigation/redirect-on-reload-updates-history-item.html

[EWS Watchlist]

Created attachment 330462 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[EWS Watchlist]

Comment on attachment 330458 [details]
Patch

Attachment 330458 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/5925423

New failing tests:
imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event.https.html
http/tests/navigation/post-frames-goback1-uncached.html

[EWS Watchlist]

Created attachment 330464 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[EWS Watchlist]

Comment on attachment 330458 [details]
Patch

Attachment 330458 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/5925438

New failing tests:
http/tests/navigation/statistics.html
http/tests/navigation/redirect-on-back-updates-history-item.html
http/tests/navigation/post-frames-goback1-uncached.html
http/tests/navigation/redirect-on-reload-updates-history-item.html

[EWS Watchlist]

Created attachment 330465 [details]
Archive of layout-test-results from ews117 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[EWS Watchlist]

Comment on attachment 330458 [details]
Patch

Attachment 330458 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/5925489

New failing tests:
imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event.https.html
http/tests/navigation/post-frames-goback1-uncached.html

[EWS Watchlist]

Created attachment 330466 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6

[youenn fablet]

Created attachment 330548 [details]
Patch

[youenn fablet]

Created attachment 330552 [details]
Patch

[youenn fablet]

Mac-32 bit failure is unrelated.

[Radar WebKit Bug Importer]

<rdar://problem/36356831>

[WebKit Commit Bot]

Comment on attachment 330552 [details]
Patch

Clearing flags on attachment: 330552

Committed r226531: <https://trac.webkit.org/changeset/226531>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Ryan Haddad]

This change appears to have caused LayoutTest http/tests/inspector/network/har/har-page.html to fail:
https://build.webkit.org/results/Apple%20Sierra%20Release%20WK2%20(Tests)/r226581%20(6756)/results.html

I can reproduce the failure locally with a build of 226531, I cannot reproduce with 226528.

[Matt Lewis]

Reverted r226531 for reason:

This caused test failures on macOS WK2.

Committed r226659: <https://trac.webkit.org/changeset/226659>

[youenn fablet]

(In reply to Ryan Haddad from comment #16)
> This change appears to have caused LayoutTest
> http/tests/inspector/network/har/har-page.html to fail:
> https://build.webkit.org/results/Apple%20Sierra%20Release%20WK2%20(Tests)/
> r226581%20(6756)/results.html
> 
> I can reproduce the failure locally with a build of 226531, I cannot
> reproduce with 226528.

Failure is 
           "cookies": [],
           "headers": "<filtered>",
           "content": {
-            "size": 3042,
+            "size": 0,
             "compression": 0,
             "mimeType": "text/html",
             "text": "<filtered text (3042)>"

size can be set to zero even if text is not empty in case of 304 responses I think.
I will change the test to filter the "size" parameter since cache may or may not contain those resources.

[youenn fablet]

Created attachment 330884 [details]
Updating test

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 330884 [details]:

The commit-queue is continuing to process your patch.

[EWS Watchlist]

Comment on attachment 330884 [details]
Updating test

Attachment 330884 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/6023842

New failing tests:
http/tests/misc/slow-loading-animated-image.html

[EWS Watchlist]

Created attachment 330947 [details]
Archive of layout-test-results from ews103 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-sierra  Platform: Mac OS X 10.12.6

[WebKit Commit Bot]

Comment on attachment 330884 [details]
Updating test

Clearing flags on attachment: 330884

Committed r226745: <https://trac.webkit.org/changeset/226745>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Commit Bot]

Re-opened since this is blocked by bug 183132