Bug 181280 - Web Inspector: ⌘G / ⇧⌘G text search does not working after closing find banner
Summary: Web Inspector: ⌘G / ⇧⌘G text search does not working after closing find banner
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-03 21:57 PST by Joseph Pecoraro
Modified: 2018-01-04 12:56 PST (History)
6 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (4.89 KB, patch)
2018-01-03 22:16 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2018-01-03 21:57:26 PST 
⌘G / ⇧⌘G text search does not working after closing find banner

This is frustrating since they work if you don't open and close the find banner.

Steps to Reproduce: (⌘G not working)
1. Inspect webkit.org
2. Show "global.js"
3. Show find banner (⌘F)
4. Search for "document"
5. Use ⌘G to find next
  => works (okay)
6. Close find banner
  => search highlights go away (okay)
7. Use ⌘G/⇧⌘G to find previous
  => doesn't work

Notes:
- Hiding the find banner apparently makes ContentBrowser call searchCleared() which clears the list of search results instead of just hiding them.
Comment 1 Radar WebKit Bug Importer 2018-01-03 21:58:00 PST 
<rdar://problem/36291176>
Comment 2 Radar WebKit Bug Importer 2018-01-03 21:58:00 PST 
<rdar://problem/36291175>
Comment 3 Joseph Pecoraro 2018-01-03 22:00:32 PST 
Test comment to see what it gets imported to.
Comment 4 Joseph Pecoraro 2018-01-03 22:16:24 PST 
Created attachment 330448 [details]
[PATCH] Proposed Fix
Comment 5 Matt Baker 2018-01-04 12:35:44 PST 
Comment on attachment 330448 [details]
[PATCH] Proposed Fix

r=me
Comment 6 WebKit Commit Bot 2018-01-04 12:56:46 PST 
Comment on attachment 330448 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 330448

Committed r226415: <https://trac.webkit.org/changeset/226415>
Comment 7 WebKit Commit Bot 2018-01-04 12:56:48 PST 
All reviewed patches have been landed.  Closing bug.