RESOLVED FIXED 181280
Web Inspector: ⌘G / ⇧⌘G text search does not working after closing find banner 
https://bugs.webkit.org/show_bug.cgi?id=181280
Summary Web Inspector: ⌘G / ⇧⌘G text search does not working after closing find banner
Joseph Pecoraro
Reported 2018-01-03 21:57:26 PST
⌘G / ⇧⌘G text search does not working after closing find banner This is frustrating since they work if you don't open and close the find banner. Steps to Reproduce: (⌘G not working) 1. Inspect webkit.org 2. Show "global.js" 3. Show find banner (⌘F) 4. Search for "document" 5. Use ⌘G to find next => works (okay) 6. Close find banner => search highlights go away (okay) 7. Use ⌘G/⇧⌘G to find previous => doesn't work Notes: - Hiding the find banner apparently makes ContentBrowser call searchCleared() which clears the list of search results instead of just hiding them.
Attachments
[PATCH] Proposed Fix (4.89 KB, patch)
2018-01-03 22:16 PST, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-01-03 21:58:00 PST
<rdar://problem/36291176>
Radar WebKit Bug Importer
Comment 2 2018-01-03 21:58:00 PST
<rdar://problem/36291175>
Joseph Pecoraro
Comment 3 2018-01-03 22:00:32 PST
Test comment to see what it gets imported to.
Joseph Pecoraro
Comment 4 2018-01-03 22:16:24 PST
Created attachment 330448 [details] [PATCH] Proposed Fix
Matt Baker
Comment 5 2018-01-04 12:35:44 PST
Comment on attachment 330448 [details] [PATCH] Proposed Fix r=me
WebKit Commit Bot
Comment 6 2018-01-04 12:56:46 PST
Comment on attachment 330448 [details] [PATCH] Proposed Fix Clearing flags on attachment: 330448 Committed r226415: <https://trac.webkit.org/changeset/226415>
WebKit Commit Bot
Comment 7 2018-01-04 12:56:48 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.