Bug 181278 - Web Inspector: "Log Value" context menu is sometimes unavailable
Summary: Web Inspector: "Log Value" context menu is sometimes unavailable
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-03 20:36 PST by Joseph Pecoraro
Modified: 2018-01-03 21:58 PST (History)
5 users (show)

See Also:


Attachments
[IMAGE] Issue in Action (453.92 KB, image/png)
2018-01-03 20:37 PST, Joseph Pecoraro
no flags Details
[IMAGE] Before - First Row Truncated (99.36 KB, image/png)
2018-01-03 20:37 PST, Joseph Pecoraro
no flags Details
[IMAGE] After - No Truncation / Overlap (100.03 KB, image/png)
2018-01-03 20:37 PST, Joseph Pecoraro
no flags Details
[PATCH] Proposed Fix (2.16 KB, patch)
2018-01-03 20:43 PST, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2018-01-03 20:36:52 PST
"Log Value" context menu is sometimes unavailable

Test:
<script>
console.dir({number: 42, object: {}, array: [], string: "str"});
</script>

Steps to Reproduce:
1. Inspect test page
2. Show console
3. Expand object
  => "array" property name doesn't have "Log Value" but should

Notes:
- The console message has a floating location information which slightly overlaps the first tree element and adjusts the tree element's size.
- In this case that overlap is accidental, eliminating the overlap eliminates the unexpected behavior.
- Overlap happens because an expanded object title is 13px tall instead of 16px like all TreeElement rows (and the Location link info)
Comment 1 Joseph Pecoraro 2018-01-03 20:37:01 PST
<rdar://problem/36281649>
Comment 2 Joseph Pecoraro 2018-01-03 20:37:21 PST
Created attachment 330441 [details]
[IMAGE] Issue in Action
Comment 3 Joseph Pecoraro 2018-01-03 20:37:40 PST
Created attachment 330442 [details]
[IMAGE] Before - First Row Truncated
Comment 4 Joseph Pecoraro 2018-01-03 20:37:56 PST
Created attachment 330443 [details]
[IMAGE] After - No Truncation / Overlap
Comment 5 Joseph Pecoraro 2018-01-03 20:43:16 PST
Created attachment 330444 [details]
[PATCH] Proposed Fix
Comment 6 Devin Rousso 2018-01-03 21:37:49 PST
Comment on attachment 330444 [details]
[PATCH] Proposed Fix

r=me.  Neat fix!  =D
Comment 7 WebKit Commit Bot 2018-01-03 21:58:29 PST
Comment on attachment 330444 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 330444

Committed r226394: <https://trac.webkit.org/changeset/226394>
Comment 8 WebKit Commit Bot 2018-01-03 21:58:30 PST
All reviewed patches have been landed.  Closing bug.