Bug 181276 – Storage Access API: Remove JavaScript confirm() prompt from Document::requestStorageAccess()

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[John Wilander]

This is an existing FIXME in the code. The JavaScript confirm() prompt has been there for demo purposes only.

[Radar WebKit Bug Importer]

<rdar://problem/36290463>

[John Wilander]

Created attachment 330447 [details]
Patch

[Alex Christensen]

Comment on attachment 330447 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330447&action=review

> LayoutTests/ChangeLog:10
> +        Two test cases are deleted since the user has no way
> +        to deny access through a prompt anymore. The rest

Let's just skip them.  They're still valuable tests, right?  We can add plumbing to get them to work the new way.

[John Wilander]

(In reply to Alex Christensen from comment #3)
> Comment on attachment 330447 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=330447&action=review
> 
> > LayoutTests/ChangeLog:10
> > +        Two test cases are deleted since the user has no way
> > +        to deny access through a prompt anymore. The rest
> 
> Let's just skip them.  They're still valuable tests, right?  We can add
> plumbing to get them to work the new way.

I’m OK just skipping them but there is no reason to have them in this version of the feature. No prompt => no way for the user to deny access. The rest still applies, such as required user gesture.

[Brent Fulgham]

Comment on attachment 330447 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330447&action=review

>>> LayoutTests/ChangeLog:10
>>> +        to deny access through a prompt anymore. The rest
>> 
>> Let's just skip them.  They're still valuable tests, right?  We can add plumbing to get them to work the new way.
> 
> I’m OK just skipping them but there is no reason to have them in this version of the feature. No prompt => no way for the user to deny access. The rest still applies, such as required user gesture.

I agree -- let's remove the tests and we can add some variant of them back if we decide we want to revisit prompting in the future.

[John Wilander]

Comment on attachment 330447 [details]
Patch

OK, committing as is. Alex, all the test infrastructure for prompt tests is still there.

[WebKit Commit Bot]

Comment on attachment 330447 [details]
Patch

Clearing flags on attachment: 330447

Committed r226409: <https://trac.webkit.org/changeset/226409>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.