Bug 181275 - Web Inspector: RTL - DOM Tree Element selection doesn't work
Summary: Web Inspector: RTL - DOM Tree Element selection doesn't work
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-03 20:31 PST by Joseph Pecoraro
Modified: 2018-01-03 21:57 PST (History)
5 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (3.05 KB, patch)
2018-01-03 20:34 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2018-01-03 20:31:36 PST 
RTL - DOM Tree Element selection doesn't work.

Steps to Reproduce:
1. Inspect webkit.org
2. Configure Web Inspector for RTL Layout Direction
3. Inspect the "Feature Status" link at the top of the page
4. Try to use the DOM Tree in the Elements Tab
  => Selection always goes to the top level parent and not the node you selected.

Notes:
- Algorithm in TreeOutline.prototype.treeElementFromEvent adjusts `x` used for elementFromPoint but doesn't take into account layout direction.
Comment 1 Radar WebKit Bug Importer 2018-01-03 20:32:06 PST 
<rdar://problem/36290450>
Comment 2 Joseph Pecoraro 2018-01-03 20:34:14 PST 
Created attachment 330438 [details]
[PATCH] Proposed Fix
Comment 3 Devin Rousso 2018-01-03 21:36:44 PST 
Comment on attachment 330438 [details]
[PATCH] Proposed Fix

r=me
Comment 4 WebKit Commit Bot 2018-01-03 21:57:26 PST 
Comment on attachment 330438 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 330438

Committed r226392: <https://trac.webkit.org/changeset/226392>
Comment 5 WebKit Commit Bot 2018-01-03 21:57:28 PST 
All reviewed patches have been landed.  Closing bug.