Bug 181265 – Add "noInline" to $vm

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Michael Saboff]

We should add noInline() function in the JSC shell to $vm so it can be used in Web tests.

[Radar WebKit Bug Importer]

<rdar://problem/36287150>

[Michael Saboff]

Created attachment 330420 [details]
Patch

[EWS Watchlist]

Attachment 330420 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/tools/JSDollarVM.cpp:1174:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Mark Lam]

Comment on attachment 330420 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330420&action=review

r=me with style fix.

> Source/JavaScriptCore/tools/JSDollarVM.cpp:1175
> +    FunctionExecutable* executable = jsDynamicCast<FunctionExecutable*>(vm,
> +                                                                        theFunction->executable());
> +    return executable;

Please fix style issue on line 1174.  Maybe just put this in one line:
    return jsDynamicCast<FunctionExecutable*>(vm, theFunction->executable());

[Michael Saboff]

(In reply to Mark Lam from comment #4)
> Comment on attachment 330420 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=330420&action=review
> 
> r=me with style fix.
> 
> > Source/JavaScriptCore/tools/JSDollarVM.cpp:1175
> > +    FunctionExecutable* executable = jsDynamicCast<FunctionExecutable*>(vm,
> > +                                                                        theFunction->executable());
> > +    return executable;
> 
> Please fix style issue on line 1174.  Maybe just put this in one line:
>     return jsDynamicCast<FunctionExecutable*>(vm, theFunction->executable());

Thanks.

Fixed locally.

[Michael Saboff]

Committed r226384: <https://trac.webkit.org/changeset/226384>