Bug 181265 - Add "noInline" to $vm
Summary: Add "noInline" to $vm
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-03 16:20 PST by Michael Saboff
Modified: 2022-02-27 23:30 PST (History)
5 users (show)

See Also:


Attachments
Patch (2.79 KB, patch)
2018-01-03 16:25 PST, Michael Saboff
mark.lam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2018-01-03 16:20:00 PST
We should add noInline() function in the JSC shell to $vm so it can be used in Web tests.
Comment 1 Radar WebKit Bug Importer 2018-01-03 16:20:45 PST
<rdar://problem/36287150>
Comment 2 Michael Saboff 2018-01-03 16:25:05 PST
Created attachment 330420 [details]
Patch
Comment 3 EWS Watchlist 2018-01-03 16:27:14 PST
Attachment 330420 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/tools/JSDollarVM.cpp:1174:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Mark Lam 2018-01-03 16:31:42 PST
Comment on attachment 330420 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330420&action=review

r=me with style fix.

> Source/JavaScriptCore/tools/JSDollarVM.cpp:1175
> +    FunctionExecutable* executable = jsDynamicCast<FunctionExecutable*>(vm,
> +                                                                        theFunction->executable());
> +    return executable;

Please fix style issue on line 1174.  Maybe just put this in one line:
    return jsDynamicCast<FunctionExecutable*>(vm, theFunction->executable());
Comment 5 Michael Saboff 2018-01-03 16:47:58 PST
(In reply to Mark Lam from comment #4)
> Comment on attachment 330420 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=330420&action=review
> 
> r=me with style fix.
> 
> > Source/JavaScriptCore/tools/JSDollarVM.cpp:1175
> > +    FunctionExecutable* executable = jsDynamicCast<FunctionExecutable*>(vm,
> > +                                                                        theFunction->executable());
> > +    return executable;
> 
> Please fix style issue on line 1174.  Maybe just put this in one line:
>     return jsDynamicCast<FunctionExecutable*>(vm, theFunction->executable());

Thanks.

Fixed locally.
Comment 6 Michael Saboff 2018-01-03 16:55:43 PST
Committed r226384: <https://trac.webkit.org/changeset/226384>