Bug 181259 - Remove WebCore::IOSApplication::isWebApp()
Summary: Remove WebCore::IOSApplication::isWebApp()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-03 14:16 PST by David Quesada
Modified: 2019-10-15 14:14 PDT (History)
5 users (show)

See Also:

Attachments
Patch (6.61 KB, patch)
2019-10-05 15:11 PDT, David Quesada 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Quesada 2018-01-03 14:16:50 PST 
This check isn't needed anymore since com.apple.webapp no longer uses WebKit directly. It is also subtly wrong since com.apple.webapp isn't the only bundle id where these hacks would have been needed. We should remove it.
Comment 1 David Quesada 2019-10-05 15:11:27 PDT 
Created attachment 380290 [details]
Patch
Comment 2 WebKit Commit Bot 2019-10-14 16:24:08 PDT 
Comment on attachment 380290 [details]
Patch

Clearing flags on attachment: 380290

Committed r251108: <https://trac.webkit.org/changeset/251108>
Comment 3 WebKit Commit Bot 2019-10-14 16:24:10 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Darin Adler 2019-10-15 10:04:23 PDT 
Comment on attachment 380290 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=380290&action=review

> Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:251
>      // FIXME: Ideally we should just have Safari, WebApp, and webbookmarksd create a data store with

A bit peculiar that this comment still mentions WebApp.
Comment 5 Ling Ho 2019-10-15 14:14:12 PDT 
<rdar://problem/56269442>