Bug 181253 – REGRESSION: Web Inspector: Debugger tab doesn't restore selected resource on reload

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

Debugger tab doesn't restore selected resource on reload

Steps to Reproduce:
1. Inspect webkit.org
2. Show Debugger tab
3. Select "global.js"
4. Reload
  => Expected global.js to be selected, instead webkit.org (document resource) was.

Notes:
- Following DebuggerSidebarPanel.prototype.restoreStateFromCookie has:

        ...
        else if (cookie[WI.DebuggerSidebarPanel.SelectedAssertionsCookieKey])
            this._assertionsBreakpointTreeElement.revealAndSelect();
        else if (cookie[WI.DebuggerSidebarPanel.SelectedAllRequestsCookieKey])
            if (this._xhrBreakpointTreeController)
                this._xhrBreakpointTreeController.revealAndSelect(WI.domDebuggerManager.allRequestsBreakpoint);
        else
            super.restoreStateFromCookie(cookie, relaxedMatchDelay);

Which actually executes as:

        ...
        else if (cookie[WI.DebuggerSidebarPanel.SelectedAssertionsCookieKey])
            this._assertionsBreakpointTreeElement.revealAndSelect();
        else if (cookie[WI.DebuggerSidebarPanel.SelectedAllRequestsCookieKey])
            if (this._xhrBreakpointTreeController)
                this._xhrBreakpointTreeController.revealAndSelect(WI.domDebuggerManager.allRequestsBreakpoint);
            else
                super.restoreStateFromCookie(cookie, relaxedMatchDelay);

Oops.

[Radar WebKit Bug Importer]

<rdar://problem/36280564>

[Joseph Pecoraro]

Created attachment 330408 [details]
[PATCH] Proposed Fix

[Matt Baker]

Comment on attachment 330408 [details]
[PATCH] Proposed Fix

r=me

[WebKit Commit Bot]

Comment on attachment 330408 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 330408

Committed r226374: <https://trac.webkit.org/changeset/226374>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.