Bug 181220 - Add a WebAuthentication runtime feature flag
Summary: Add a WebAuthentication runtime feature flag
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jiewen Tan
URL:
Keywords: InRadar
Depends on:
Blocks: 181943
  Show dependency tree / graph
 
Reported: 2018-01-02 14:27 PST by Jiewen Tan
Modified: 2018-01-22 13:30 PST (History)
8 users (show)

See Also:

Attachments
Patch (23.44 KB, patch)
2018-01-02 14:40 PST, Jiewen Tan 		bfulgham: review+
Details | Formatted Diff | Diff
Patch for landing (23.70 KB, patch)
2018-01-02 15:29 PST, Jiewen Tan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jiewen Tan 2018-01-02 14:27:44 PST 
Add a WebAuthentication runtime feature flag.
Comment 1 Jiewen Tan 2018-01-02 14:28:16 PST 
<rdar://problem/36055305>
Comment 2 Jiewen Tan 2018-01-02 14:40:24 PST 
Created attachment 330337 [details]
Patch
Comment 3 Brent Fulgham 2018-01-02 15:16:00 PST 
Comment on attachment 330337 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330337&action=review

R=me

> Source/WebKit/ChangeLog:8
> +

Can you paste the same explanation here, and in the other ChangeLogs? “Renaming Credentials... to WebAuthN”
Comment 4 Jiewen Tan 2018-01-02 15:29:52 PST 
Created attachment 330345 [details]
Patch for landing
Comment 5 Jiewen Tan 2018-01-02 15:38:07 PST 
Comment on attachment 330337 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330337&action=review

Thanks Brent for r+ my patch.

>> Source/WebKit/ChangeLog:8
>> +
> 
> Can you paste the same explanation here, and in the other ChangeLogs? “Renaming Credentials... to WebAuthN”

Fixed.
Comment 6 WebKit Commit Bot 2018-01-02 16:10:14 PST 
Comment on attachment 330345 [details]
Patch for landing

Clearing flags on attachment: 330345

Committed r226341: <https://trac.webkit.org/changeset/226341>