Bug 181218 - Fix the build on platforms where UICurrentUserInterfaceIdiomIsPad is defined to false
Summary: Fix the build on platforms where UICurrentUserInterfaceIdiomIsPad is defined ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-02 12:30 PST by Tim Horton
Modified: 2018-01-02 13:18 PST (History)
7 users (show)

See Also:


Attachments
Patch (10.97 KB, patch)
2018-01-02 12:31 PST, Tim Horton
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2018-01-02 12:30:55 PST
Fix the build on platforms where UICurrentUserInterfaceIdiomIsPad is defined to false
Comment 1 Tim Horton 2018-01-02 12:31:17 PST
Created attachment 330328 [details]
Patch
Comment 2 Tim Horton 2018-01-02 12:32:19 PST
Someone might have some idea about a better way. I started with #pragma disabling the warning, but it was in a lot of places which is kind of annoying.
Comment 3 EWS Watchlist 2018-01-02 12:33:52 PST
Attachment 330328 [details] did not pass style-queue:


ERROR: Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1158:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 WebKit Commit Bot 2018-01-02 13:06:49 PST
Comment on attachment 330328 [details]
Patch

Clearing flags on attachment: 330328

Committed r226335: <https://trac.webkit.org/changeset/226335>
Comment 5 WebKit Commit Bot 2018-01-02 13:06:51 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-01-02 13:18:53 PST
<rdar://problem/36261392>