Bug 181213 - Select service worker for documents with data/blob URLS
Summary: Select service worker for documents with data/blob URLS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-02 08:43 PST by youenn fablet
Modified: 2018-01-03 09:37 PST (History)
7 users (show)

See Also:


Attachments
Patch (5.89 KB, patch)
2018-01-02 08:51 PST, youenn fablet
no flags Details | Formatted Diff | Diff
Patch for landing (5.99 KB, patch)
2018-01-03 05:39 PST, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2018-01-02 08:43:03 PST
As per https://w3c.github.io/ServiceWorker/#selection, local URLs documents should reuse their parent service worker if any.
Comment 1 youenn fablet 2018-01-02 08:51:13 PST
Created attachment 330320 [details]
Patch
Comment 2 Alex Christensen 2018-01-02 10:52:10 PST
Comment on attachment 330320 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330320&action=review

> Source/WebCore/loader/DocumentLoader.cpp:871
> +    // FIXME: Add filesystem and about schemes.

Why not just do this now?
Comment 3 youenn fablet 2018-01-02 15:24:35 PST
Comment on attachment 330320 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330320&action=review

>> Source/WebCore/loader/DocumentLoader.cpp:871
>> +    // FIXME: Add filesystem and about schemes.
> 
> Why not just do this now?

I am not sure that any WebKit client is supporting the filesystem scheme (it is different from file scheme). Except for being standard compliant, I don't see a point in adding that check.
about scheme makes more sense, since we have about:blank. Do we have more than that? Maybe this is adding some extra IPC for almost nothing as well.
Comment 4 youenn fablet 2018-01-03 05:39:29 PST
Created attachment 330375 [details]
Patch for landing
Comment 5 youenn fablet 2018-01-03 05:41:00 PST
(In reply to youenn fablet from comment #4)
> Created attachment 330375 [details]
> Patch for landing

Removed the FIXME, added "about" since WebKit has support for it but not "filesystem".
Comment 6 youenn fablet 2018-01-03 06:11:16 PST
rdar://problem/36164593
Comment 7 WebKit Commit Bot 2018-01-03 09:32:34 PST
Comment on attachment 330375 [details]
Patch for landing

Clearing flags on attachment: 330375

Committed r226361: <https://trac.webkit.org/changeset/226361>
Comment 8 WebKit Commit Bot 2018-01-03 09:32:35 PST
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2018-01-03 09:37:44 PST
<rdar://problem/36276805>