RESOLVED FIXED 181213
Select service worker for documents with data/blob URLS 
https://bugs.webkit.org/show_bug.cgi?id=181213
Summary Select service worker for documents with data/blob URLS
youenn fablet
Reported 2018-01-02 08:43:03 PST
As per https://w3c.github.io/ServiceWorker/#selection, local URLs documents should reuse their parent service worker if any.
Attachments
Patch (5.89 KB, patch)
2018-01-02 08:51 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.99 KB, patch)
2018-01-03 05:39 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2018-01-02 08:51:13 PST
Created attachment 330320 [details] Patch
Alex Christensen
Comment 2 2018-01-02 10:52:10 PST
Comment on attachment 330320 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=330320&action=review > Source/WebCore/loader/DocumentLoader.cpp:871 > + // FIXME: Add filesystem and about schemes. Why not just do this now?
youenn fablet
Comment 3 2018-01-02 15:24:35 PST
Comment on attachment 330320 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=330320&action=review >> Source/WebCore/loader/DocumentLoader.cpp:871 >> + // FIXME: Add filesystem and about schemes. > > Why not just do this now? I am not sure that any WebKit client is supporting the filesystem scheme (it is different from file scheme). Except for being standard compliant, I don't see a point in adding that check. about scheme makes more sense, since we have about:blank. Do we have more than that? Maybe this is adding some extra IPC for almost nothing as well.
youenn fablet
Comment 4 2018-01-03 05:39:29 PST
Created attachment 330375 [details] Patch for landing
youenn fablet
Comment 5 2018-01-03 05:41:00 PST
(In reply to youenn fablet from comment #4) > Created attachment 330375 [details] > Patch for landing Removed the FIXME, added "about" since WebKit has support for it but not "filesystem".
youenn fablet
Comment 6 2018-01-03 06:11:16 PST
rdar://problem/36164593
WebKit Commit Bot
Comment 7 2018-01-03 09:32:34 PST
Comment on attachment 330375 [details] Patch for landing Clearing flags on attachment: 330375 Committed r226361: <https://trac.webkit.org/changeset/226361>
WebKit Commit Bot
Comment 8 2018-01-03 09:32:35 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2018-01-03 09:37:44 PST
<rdar://problem/36276805>
Note You need to log in before you can comment on or make changes to this bug.