Bug 181188 - [Attachment Support] Remove current macOS support for dragging file-backed attachments
Summary: [Attachment Support] Remove current macOS support for dragging file-backed at...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-29 12:50 PST by Wenson Hsieh
Modified: 2018-01-02 13:00 PST (History)
5 users (show)

See Also:

Attachments
Patch (26.54 KB, patch)
2017-12-29 14:01 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Fix Win/GTK builds (28.08 KB, patch)
2017-12-29 14:43 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2017-12-29 12:50:58 PST 
No client (Mail included) currently exercises these codepaths.

In subsequent patches, I'm reimplementing this feature in a way that is (1) compatible with dragging on iOS, and (2) is generalizable to non-file-backed blobs (i.e. Files that are created entirely via bindings, and thus have no references to file paths on the system).
Comment 1 Wenson Hsieh 2017-12-29 14:01:44 PST 
Created attachment 330258 [details]
Patch
Comment 2 Wenson Hsieh 2017-12-29 14:43:01 PST 
Created attachment 330259 [details]
Fix Win/GTK builds
Comment 3 Wenson Hsieh 2017-12-30 11:09:37 PST 
Comment on attachment 330259 [details]
Fix Win/GTK builds

Thanks Dan!
Comment 4 WebKit Commit Bot 2017-12-30 11:30:44 PST 
Comment on attachment 330259 [details]
Fix Win/GTK builds

Clearing flags on attachment: 330259

Committed r226312: <https://trac.webkit.org/changeset/226312>
Comment 5 WebKit Commit Bot 2017-12-30 11:30:45 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-01-02 13:00:29 PST 
<rdar://problem/36260924>