Bug 181187 – [WPE][GTK] Implement the assignment of ProcessIdentifiers to child processes

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Brady Eidson]

Non-Cocoa ports need to implement the assignment of ProcessIdentifiers to child processes in WK2

https://trac.webkit.org/changeset/226308/webkit added the notion of a "ProcessIdentifier" in child processes.
The Identifier is created by the UI process and vended out to child processes as they are launched.

I added the initialization of the identifier in the Cocoa process launching code, but added it for the Unixes was not something I could do blind.

Somebody with the expertise and build setup needs to:
- Make sure the LaunchOptions ProcessIdentifier in the UI process propagates to the child process (This will probably be done via argv?)
- Make sure the child process extracts that process identifier and sets it properly on the ChildProcessInitializationParameters
- Remove the code in ChildProcess::initialize that handles a missing process identifier as it is invalid for it to be missing.

[Michael Catanzaro]

It looks like we only have ProcessLauncherGLib and ProcessLauncherMac. I'll look into this for ProcessLauncherGLib, which covers the WPE and GTK ports. Those are the only upstream WK2 ports right now (asides the WIP Windows port) so I believe no other ports should need to be updated.

[Michael Catanzaro]

(And thanks for filing the bug. ;)

[Carlos Alberto Lopez Perez]

What about non-Glib and non-Cocoa ports like WinCairo? I guess this needs to be implemented there as well, doesn't it?

[Michael Catanzaro]

(In reply to Carlos Alberto Lopez Perez from comment #3)
> What about non-Glib and non-Cocoa ports like WinCairo? I guess this needs to
> be implemented there as well, doesn't it?

This is for WK2. Windows support is WIP, and I don't see a ProcessLauncherWin yet.

[Michael Catanzaro]

Created attachment 330300 [details]
Patch

[Brady Eidson]

Comment on attachment 330300 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330300&action=review

LGTM

> Source/WebKit/UIProcess/Launcher/glib/ProcessLauncherGLib.cpp:97
> +    GUniquePtr<gchar> processIdentifier(g_strdup_printf("%" PRIu64, m_launchOptions.processIdentifier.toUInt64()));

Whole patch is precisely what I tried to do blind except I had no way of verifying this line. :) Thanks!

[WebKit Commit Bot]

Comment on attachment 330300 [details]
Patch

Clearing flags on attachment: 330300

Committed r226327: <https://trac.webkit.org/changeset/226327>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Michael Catanzaro]

I broke the plugin process.

[Michael Catanzaro]

Committed r226337: <https://trac.webkit.org/changeset/226337>