Bug 181186 - Remove std::chrono completely
Summary: Remove std::chrono completely
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-28 19:42 PST by Yusuke Suzuki
Modified: 2018-02-13 01:59 PST (History)
11 users (show)

See Also:


Attachments
Patch (182.30 KB, patch)
2017-12-28 19:50 PST, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
Patch (184.39 KB, patch)
2017-12-28 20:12 PST, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
Patch (184.61 KB, patch)
2017-12-28 20:29 PST, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
Patch (184.71 KB, patch)
2017-12-28 20:56 PST, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews105 for mac-elcapitan-wk2 (2.76 MB, application/zip)
2017-12-28 22:08 PST, EWS Watchlist
no flags Details
Archive of layout-test-results from ews101 for mac-elcapitan (2.31 MB, application/zip)
2017-12-28 22:09 PST, EWS Watchlist
no flags Details
Archive of layout-test-results from ews116 for mac-elcapitan (3.49 MB, application/zip)
2017-12-28 22:38 PST, EWS Watchlist
no flags Details
Archive of layout-test-results from ews126 for ios-simulator-wk2 (8.47 MB, application/zip)
2017-12-28 22:41 PST, EWS Watchlist
no flags Details
Patch (184.69 KB, patch)
2017-12-29 10:19 PST, Yusuke Suzuki
achristensen: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2017-12-28 19:42:22 PST
Remove std::chrono completely
Comment 1 Yusuke Suzuki 2017-12-28 19:50:48 PST
Created attachment 330243 [details]
Patch
Comment 2 EWS Watchlist 2017-12-28 19:52:53 PST
Attachment 330243 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/indexeddb/server/IDBServer.h:104:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/WebCookieManagerProxy.h:71:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/WebCookieManagerProxy.cpp:143:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/Plugins/PluginProcessManager.cpp:112:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/API/C/WKCookieManager.cpp:62:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebKit/UIProcess/API/C/WKCookieManager.cpp:62:  Missing space inside { }.  [whitespace/braces] [5]
ERROR: Source/WebCore/Modules/indexeddb/server/IDBServer.cpp:499:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/network/curl/CurlCacheEntry.cpp:304:  One line control clauses should not use braces.  [whitespace/braces] [4]
ERROR: Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:145:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/NetworkProcess/cache/NetworkCache.h:120:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/NetworkProcess/cache/NetworkCache.cpp:600:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm:177:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm:192:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.cpp:950:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/win/SearchPopupMenuWin.cpp:95:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebKit/NetworkProcess/NetworkProcess.h:206:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/Plugins/PluginProcessManager.h:64:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.h:68:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.cpp:96:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/NetworkProcess/soup/NetworkProcessSoup.cpp:159:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/Plugins/PluginProcessProxy.cpp:132:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/Plugins/PluginProcessProxy.h:82:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 22 in 123 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Yusuke Suzuki 2017-12-28 20:12:26 PST
Created attachment 330245 [details]
Patch
Comment 4 EWS Watchlist 2017-12-28 20:14:01 PST
Attachment 330245 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/indexeddb/server/IDBServer.h:104:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/WebCookieManagerProxy.h:71:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/WebCookieManagerProxy.cpp:143:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/Plugins/PluginProcessManager.cpp:112:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/API/C/WKCookieManager.cpp:62:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebKit/UIProcess/API/C/WKCookieManager.cpp:62:  Missing space inside { }.  [whitespace/braces] [5]
ERROR: Source/WebCore/Modules/indexeddb/server/IDBServer.cpp:499:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/network/curl/CurlCacheEntry.cpp:304:  One line control clauses should not use braces.  [whitespace/braces] [4]
ERROR: Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:145:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/NetworkProcess/cache/NetworkCache.h:120:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/NetworkProcess/cache/NetworkCache.cpp:600:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm:177:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm:192:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.cpp:950:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/win/SearchPopupMenuWin.cpp:95:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebKit/NetworkProcess/NetworkProcess.h:206:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/Plugins/PluginProcessManager.h:64:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.h:69:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.cpp:96:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/NetworkProcess/soup/NetworkProcessSoup.cpp:159:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/Plugins/PluginProcessProxy.cpp:132:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/Plugins/PluginProcessProxy.h:82:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 22 in 125 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Yusuke Suzuki 2017-12-28 20:29:02 PST
Created attachment 330246 [details]
Patch
Comment 6 EWS Watchlist 2017-12-28 20:31:39 PST
Attachment 330246 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/indexeddb/server/IDBServer.h:104:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/WebCookieManagerProxy.h:71:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/WebCookieManagerProxy.cpp:143:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/Plugins/PluginProcessManager.cpp:112:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/API/C/WKCookieManager.cpp:62:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebKit/UIProcess/API/C/WKCookieManager.cpp:62:  Missing space inside { }.  [whitespace/braces] [5]
ERROR: Source/WebCore/Modules/indexeddb/server/IDBServer.cpp:499:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/network/curl/CurlCacheEntry.cpp:304:  One line control clauses should not use braces.  [whitespace/braces] [4]
ERROR: Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:145:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/NetworkProcess/cache/NetworkCache.h:120:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/NetworkProcess/cache/NetworkCache.cpp:600:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm:177:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm:192:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.cpp:950:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/win/SearchPopupMenuWin.cpp:95:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebKit/NetworkProcess/NetworkProcess.h:206:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/Plugins/PluginProcessManager.h:64:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.h:69:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.cpp:96:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/NetworkProcess/soup/NetworkProcessSoup.cpp:159:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/Plugins/PluginProcessProxy.cpp:132:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/Plugins/PluginProcessProxy.h:82:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 22 in 125 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Yusuke Suzuki 2017-12-28 20:56:48 PST
Created attachment 330247 [details]
Patch
Comment 8 EWS Watchlist 2017-12-28 20:59:23 PST
Attachment 330247 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/indexeddb/server/IDBServer.h:104:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/WebCookieManagerProxy.h:71:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/WebCookieManagerProxy.cpp:143:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/Plugins/PluginProcessManager.cpp:112:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/API/C/WKCookieManager.cpp:62:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebKit/UIProcess/API/C/WKCookieManager.cpp:62:  Missing space inside { }.  [whitespace/braces] [5]
ERROR: Source/WebCore/Modules/indexeddb/server/IDBServer.cpp:499:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:145:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/NetworkProcess/cache/NetworkCache.h:120:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/NetworkProcess/cache/NetworkCache.cpp:600:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm:177:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm:192:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.cpp:950:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/win/SearchPopupMenuWin.cpp:95:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebKit/NetworkProcess/NetworkProcess.h:206:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/Plugins/PluginProcessManager.h:64:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.h:69:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.cpp:96:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/NetworkProcess/soup/NetworkProcessSoup.cpp:159:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/Plugins/PluginProcessProxy.cpp:132:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/Plugins/PluginProcessProxy.h:82:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 21 in 125 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 9 EWS Watchlist 2017-12-28 22:08:25 PST
Comment on attachment 330247 [details]
Patch

Attachment 330247 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/5857909

New failing tests:
http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-image-in-main-frame.html
http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-image-in-iframe.html
http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-script-in-iframe.html
http/tests/cache/cache-redirections.html
http/tests/cache/disk-cache/disk-cache-redirect.html
http/tests/loading/main-resource-delegates-on-back-navigation.html
http/tests/cache/disk-cache/disk-cache-307-status-code.html
imported/w3c/web-platform-tests/fetch/http-cache/heuristic.html
http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-css-in-main-frame.html
http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-image-in-iframe-with-enforced-and-report-policies.html
http/tests/security/clipboard/copy-paste-html-cross-origin-iframe-across-origin.html
http/tests/cache/display-image-unset-allows-cached-image-load.html
http/tests/inspector/network/resource-response-source-memory-cache.html
http/tests/cache/disk-cache/disk-cache-404-status-code.html
http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/proper-open-window-upgrades.html
http/tests/cache/disk-cache/disk-cache-last-modified.html
http/tests/loading/server-redirect-for-provisional-load-caching.html
http/tests/workers/service/cors-image-fetch.html
http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-script-in-main-frame.html
http/tests/cache/stylesheet-sharing.html
http/tests/subresource-integrity/sri-enabled-with-setting.html
Comment 10 EWS Watchlist 2017-12-28 22:08:26 PST
Created attachment 330250 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 11 EWS Watchlist 2017-12-28 22:09:10 PST
Comment on attachment 330247 [details]
Patch

Attachment 330247 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/5857868

New failing tests:
http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-image-in-main-frame.html
http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-image-in-iframe.html
http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-script-in-iframe.html
http/tests/loading/main-resource-delegates-on-back-navigation.html
http/tests/cache/stylesheet-sharing.html
http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-css-in-main-frame.html
http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-image-in-iframe-with-enforced-and-report-policies.html
http/tests/security/clipboard/copy-paste-html-cross-origin-iframe-across-origin.html
http/tests/cache/subresource-expiration-2.html
http/tests/inspector/network/resource-response-source-memory-cache.html
http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/proper-open-window-upgrades.html
http/tests/cache/display-image-unset-allows-cached-image-load.html
http/tests/loading/server-redirect-for-provisional-load-caching.html
http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-script-in-main-frame.html
http/tests/loading/redirect-methods.html
http/tests/subresource-integrity/sri-enabled-with-setting.html
Comment 12 EWS Watchlist 2017-12-28 22:09:12 PST
Created attachment 330251 [details]
Archive of layout-test-results from ews101 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 13 EWS Watchlist 2017-12-28 22:38:05 PST
Comment on attachment 330247 [details]
Patch

Attachment 330247 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/5857924

New failing tests:
http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-image-in-main-frame.html
http/tests/loading/main-resource-delegates-on-back-navigation.html
http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-css-in-main-frame.html
http/tests/cache/subresource-expiration-2.html
http/tests/security/clipboard/drag-drop-html-cross-origin-iframe-in-same-origin.html
http/tests/security/cross-origin-cached-scripts-parallel.html
http/tests/loading/server-redirect-for-provisional-load-caching.html
http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-script-in-main-frame.html
http/tests/loading/redirect-methods.html
http/tests/subresource-integrity/sri-enabled-with-setting.html
http/tests/inspector/network/resource-response-source-memory-cache.html
http/tests/security/clipboard/copy-paste-html-cross-origin-iframe-in-same-origin.html
http/tests/cache/display-image-unset-allows-cached-image-load.html
http/tests/css/shape-image-file.html
http/tests/security/clipboard/copy-paste-html-cross-origin-iframe-across-origin.html
http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/proper-open-window-upgrades.html
http/tests/xmlhttprequest/xmlhttprequest-abort-readyState-shouldDispatchEvent.html
http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-image-in-iframe.html
http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-script-in-iframe.html
http/tests/xmlhttprequest/xmlhttprequest-responseXML-exception.html
http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-image-in-iframe-with-enforced-and-report-policies.html
http/tests/xmlhttprequest/xmlhttprequest-addEventListener-onProgress.html
http/tests/cache/stylesheet-sharing.html
Comment 14 EWS Watchlist 2017-12-28 22:38:07 PST
Created attachment 330252 [details]
Archive of layout-test-results from ews116 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 15 EWS Watchlist 2017-12-28 22:41:44 PST
Comment on attachment 330247 [details]
Patch

Attachment 330247 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/5857923

New failing tests:
http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-image-in-main-frame.html
http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-image-in-iframe.html
http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-script-in-iframe.html
http/tests/cache/disk-cache/disk-cache-204-status-code.html
http/tests/cache/disk-cache/disk-cache-307-status-code.html
imported/w3c/web-platform-tests/fetch/http-cache/heuristic.html
http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-css-in-main-frame.html
http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-image-in-iframe-with-enforced-and-report-policies.html
http/tests/security/clipboard/copy-paste-html-cross-origin-iframe-across-origin.html
http/tests/subresource-integrity/sri-enabled-with-setting.html
http/tests/cache/disk-cache/disk-cache-last-modified.html
http/tests/cache/disk-cache/disk-cache-404-status-code.html
http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/proper-open-window-upgrades.html
http/tests/cache/display-image-unset-allows-cached-image-load.html
http/tests/loading/server-redirect-for-provisional-load-caching.html
http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-script-in-main-frame.html
http/tests/cache/stylesheet-sharing.html
http/tests/loading/main-resource-delegates-on-back-navigation.html
Comment 16 EWS Watchlist 2017-12-28 22:41:45 PST
Created attachment 330253 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6
Comment 17 Yusuke Suzuki 2017-12-29 10:19:42 PST
Created attachment 330256 [details]
Patch
Comment 18 EWS Watchlist 2017-12-29 10:21:55 PST
Attachment 330256 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/indexeddb/server/IDBServer.h:104:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/WebCookieManagerProxy.h:71:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/WebCookieManagerProxy.cpp:143:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/Plugins/PluginProcessManager.cpp:112:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/API/C/WKCookieManager.cpp:62:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebKit/UIProcess/API/C/WKCookieManager.cpp:62:  Missing space inside { }.  [whitespace/braces] [5]
ERROR: Source/WebCore/Modules/indexeddb/server/IDBServer.cpp:499:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:145:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/NetworkProcess/cache/NetworkCache.h:120:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/NetworkProcess/cache/NetworkCache.cpp:600:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm:177:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm:192:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.cpp:950:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/platform/win/SearchPopupMenuWin.cpp:95:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebKit/NetworkProcess/NetworkProcess.h:206:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/Plugins/PluginProcessManager.h:64:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.h:69:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/Storage/StorageProcessProxy.cpp:96:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/NetworkProcess/soup/NetworkProcessSoup.cpp:159:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/Plugins/PluginProcessProxy.cpp:132:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit/UIProcess/Plugins/PluginProcessProxy.h:82:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 21 in 125 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 19 Yusuke Suzuki 2017-12-29 11:46:53 PST
OK, the patch is ready.
Comment 20 Alex Christensen 2018-01-02 13:17:11 PST
Comment on attachment 330256 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330256&action=review

> Source/WebCore/platform/network/HTTPParsers.cpp:260
>          return { };

std::nullopt

> Source/WebKit/Platform/IPC/ArgumentCoders.cpp:53
> +    double value;
> +    if (!decoder.decode(value))

Let's keep the new pattern:
std::optional<double> time;
decoder >> time;
if (!time)
    return std::nullopt;
Comment 21 Yusuke Suzuki 2018-01-02 19:30:35 PST
Comment on attachment 330256 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330256&action=review

Thank you!

>> Source/WebCore/platform/network/HTTPParsers.cpp:260
>>          return { };
> 
> std::nullopt

Fixed.

>> Source/WebKit/Platform/IPC/ArgumentCoders.cpp:53
>> +    if (!decoder.decode(value))
> 
> Let's keep the new pattern:
> std::optional<double> time;
> decoder >> time;
> if (!time)
>     return std::nullopt;

Fixed.
Comment 22 Yusuke Suzuki 2018-01-02 19:40:04 PST
Committed r226349: <https://trac.webkit.org/changeset/226349>
Comment 23 Radar WebKit Bug Importer 2018-01-02 19:41:53 PST
<rdar://problem/36268805>
Comment 24 Antti Koivisto 2018-02-12 19:45:01 PST
Comment on attachment 330256 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330256&action=review

> Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.h:90
> -    static const unsigned version = 11;
> +    static const unsigned version = 12;

I'm not sure it was worth wiping out everyones cache content for this change. :(
Comment 25 Yusuke Suzuki 2018-02-13 01:59:37 PST
(In reply to Antti Koivisto from comment #24)
> Comment on attachment 330256 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=330256&action=review
> 
> > Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.h:90
> > -    static const unsigned version = 11;
> > +    static const unsigned version = 12;
> 
> I'm not sure it was worth wiping out everyones cache content for this
> change. :(

I believe this is one shot change: now we purge std::chrono in our tree and we are stick to Seconds / MonotonicTime / WallTime.