WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
181184
[JSC] Remove unused JSTypes
https://bugs.webkit.org/show_bug.cgi?id=181184
Summary
[JSC] Remove unused JSTypes
Yusuke Suzuki
Reported
2017-12-28 17:20:48 PST
[JSC] Remove unused JSTypes
Attachments
Patch
(2.98 KB, patch)
2017-12-28 17:22 PST
,
Yusuke Suzuki
saam
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1
2017-12-28 17:22:01 PST
Created
attachment 330237
[details]
Patch
Saam Barati
Comment 2
2017-12-28 18:12:43 PST
Comment on
attachment 330237
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=330237&action=review
> Source/JavaScriptCore/runtime/JSType.h:25 > enum JSType : uint8_t {
You don’t need to change any of these values in the LLInt?
Yusuke Suzuki
Comment 3
2017-12-30 11:04:07 PST
Comment on
attachment 330237
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=330237&action=review
>> Source/JavaScriptCore/runtime/JSType.h:25 >> enum JSType : uint8_t { > > You don’t need to change any of these values in the LLInt?
In LLInt, they are already changed to `constexpr ...`. So we do not need to change it :)
Yusuke Suzuki
Comment 4
2017-12-30 11:05:39 PST
Committed
r226311
: <
https://trac.webkit.org/changeset/226311
>
Radar WebKit Bug Importer
Comment 5
2018-01-02 12:58:57 PST
<
rdar://problem/36260879
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug