Bug 181184 - [JSC] Remove unused JSTypes
Summary: [JSC] Remove unused JSTypes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-28 17:20 PST by Yusuke Suzuki
Modified: 2018-01-02 12:58 PST (History)
8 users (show)

See Also:

Attachments
Patch (2.98 KB, patch)
2017-12-28 17:22 PST, Yusuke Suzuki 		saam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2017-12-28 17:20:48 PST 
[JSC] Remove unused JSTypes
Comment 1 Yusuke Suzuki 2017-12-28 17:22:01 PST 
Created attachment 330237 [details]
Patch
Comment 2 Saam Barati 2017-12-28 18:12:43 PST 
Comment on attachment 330237 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330237&action=review

> Source/JavaScriptCore/runtime/JSType.h:25
>  enum JSType : uint8_t {

You don’t need to change any of these values in the LLInt?
Comment 3 Yusuke Suzuki 2017-12-30 11:04:07 PST 
Comment on attachment 330237 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330237&action=review

>> Source/JavaScriptCore/runtime/JSType.h:25
>>  enum JSType : uint8_t {
> 
> You don’t need to change any of these values in the LLInt?

In LLInt, they are already changed to `constexpr ...`. So we do not need to change it :)
Comment 4 Yusuke Suzuki 2017-12-30 11:05:39 PST 
Committed r226311: <https://trac.webkit.org/changeset/226311>
Comment 5 Radar WebKit Bug Importer 2018-01-02 12:58:57 PST 
<rdar://problem/36260879>