....
<rdar://problem/35640560>
Created attachment 330207 [details] patch
Comment on attachment 330207 [details] patch r=me
Comment on attachment 330207 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=330207&action=review > JSTests/stress/async-generator-assertion.js:35 > +assert(error instanceof TypeError); Could we check exact error message? Currently without patch in STP 46, I'm receiving also TypeError: undefined is not a function (near '...x of p2...') > Source/JavaScriptCore/ChangeLog:17 > + (globalPrivate.asyncGeneratorResolve): Nit: asyncGeneratorResumeNext is missed
Comment on attachment 330207 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=330207&action=review >> JSTests/stress/async-generator-assertion.js:35 >> +assert(error instanceof TypeError); > > Could we check exact error message? Currently without patch in STP 46, I'm receiving also TypeError: undefined is not a function (near '...x of p2...') Sure. On a side note: our error messages are so bad for for...of loops. >> Source/JavaScriptCore/ChangeLog:17 >> + (globalPrivate.asyncGeneratorResolve): > > Nit: asyncGeneratorResumeNext is missed looks like prepare changelog just missed it. I'll manually add it.
Created attachment 330227 [details] patch for landing
Comment on attachment 330227 [details] patch for landing Clearing flags on attachment: 330227 Committed r226305: <https://trac.webkit.org/changeset/226305>
All reviewed patches have been landed. Closing bug.