Bug 181168 - Assertion used to determine if something is an async generator is wrong
Summary: Assertion used to determine if something is an async generator is wrong
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-26 19:15 PST by Saam Barati
Modified: 2017-12-28 10:13 PST (History)
15 users (show)

See Also:


Attachments
patch (4.21 KB, patch)
2017-12-26 19:51 PST, Saam Barati
ysuzuki: review+
Details | Formatted Diff | Diff
patch for landing (4.24 KB, patch)
2017-12-27 20:19 PST, Saam Barati
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2017-12-26 19:15:17 PST
....
Comment 1 Saam Barati 2017-12-26 19:50:54 PST
<rdar://problem/35640560>
Comment 2 Saam Barati 2017-12-26 19:51:52 PST
Created attachment 330207 [details]
patch
Comment 3 Yusuke Suzuki 2017-12-27 02:06:15 PST
Comment on attachment 330207 [details]
patch

r=me
Comment 4 GSkachkov 2017-12-27 03:59:49 PST
Comment on attachment 330207 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330207&action=review

> JSTests/stress/async-generator-assertion.js:35
> +assert(error instanceof TypeError);

Could we check exact error message? Currently without patch in STP 46, I'm receiving also TypeError: undefined is not a function (near '...x of p2...')

> Source/JavaScriptCore/ChangeLog:17
> +        (globalPrivate.asyncGeneratorResolve):

Nit: asyncGeneratorResumeNext is missed
Comment 5 Saam Barati 2017-12-27 20:15:30 PST
Comment on attachment 330207 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330207&action=review

>> JSTests/stress/async-generator-assertion.js:35
>> +assert(error instanceof TypeError);
> 
> Could we check exact error message? Currently without patch in STP 46, I'm receiving also TypeError: undefined is not a function (near '...x of p2...')

Sure.
On a side note: our error messages are so bad for for...of loops.

>> Source/JavaScriptCore/ChangeLog:17
>> +        (globalPrivate.asyncGeneratorResolve):
> 
> Nit: asyncGeneratorResumeNext is missed

looks like prepare changelog just missed it. I'll manually add it.
Comment 6 Saam Barati 2017-12-27 20:19:36 PST
Created attachment 330227 [details]
patch for landing
Comment 7 WebKit Commit Bot 2017-12-28 10:13:19 PST
Comment on attachment 330227 [details]
patch for landing

Clearing flags on attachment: 330227

Committed r226305: <https://trac.webkit.org/changeset/226305>
Comment 8 WebKit Commit Bot 2017-12-28 10:13:20 PST
All reviewed patches have been landed.  Closing bug.