Bug 181168 – Assertion used to determine if something is an async generator is wrong

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Saam Barati]

....

[Saam Barati]

<rdar://problem/35640560>

[Saam Barati]

Created attachment 330207 [details]
patch

[Yusuke Suzuki]

Comment on attachment 330207 [details]
patch

r=me

[GSkachkov]

Comment on attachment 330207 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330207&action=review

> JSTests/stress/async-generator-assertion.js:35
> +assert(error instanceof TypeError);

Could we check exact error message? Currently without patch in STP 46, I'm receiving also TypeError: undefined is not a function (near '...x of p2...')

> Source/JavaScriptCore/ChangeLog:17
> +        (globalPrivate.asyncGeneratorResolve):

Nit: asyncGeneratorResumeNext is missed

[Saam Barati]

Comment on attachment 330207 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330207&action=review

>> JSTests/stress/async-generator-assertion.js:35
>> +assert(error instanceof TypeError);
> 
> Could we check exact error message? Currently without patch in STP 46, I'm receiving also TypeError: undefined is not a function (near '...x of p2...')

Sure.
On a side note: our error messages are so bad for for...of loops.

>> Source/JavaScriptCore/ChangeLog:17
>> +        (globalPrivate.asyncGeneratorResolve):
> 
> Nit: asyncGeneratorResumeNext is missed

looks like prepare changelog just missed it. I'll manually add it.

[Saam Barati]

Created attachment 330227 [details]
patch for landing

[WebKit Commit Bot]

Comment on attachment 330227 [details]
patch for landing

Clearing flags on attachment: 330227

Committed r226305: <https://trac.webkit.org/changeset/226305>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.