Bug 181165 - [JSC] Remove std::chrono completely
Summary: [JSC] Remove std::chrono completely
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-26 15:13 PST by Yusuke Suzuki
Modified: 2018-01-02 12:59 PST (History)
13 users (show)

See Also:

Attachments
Patch (40.98 KB, patch)
2017-12-26 15:24 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (41.50 KB, patch)
2017-12-26 16:09 PST, Yusuke Suzuki 		annulen: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2017-12-26 15:13:30 PST 
[JSC] Remove std::chrono completely
Comment 1 Yusuke Suzuki 2017-12-26 15:24:04 PST 
Created attachment 330204 [details]
Patch
Comment 2 EWS Watchlist 2017-12-26 15:26:50 PST 
Attachment 330204 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:389:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
Total errors found: 1 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Konstantin Tokarev 2017-12-26 16:01:09 PST 
Comment on attachment 330204 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330204&action=review

> Source/JavaScriptCore/runtime/Watchdog.cpp:41
> +    , m_wallClockDeadline(MonotonicTime::infinity())

This variable doesn't hold wall clock time anymore

> Source/JavaScriptCore/runtime/Watchdog.cpp:135
> +    auto wallClockTime = MonotonicTime::now();

Ditto
Comment 4 Yusuke Suzuki 2017-12-26 16:05:22 PST 
Comment on attachment 330204 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330204&action=review

>> Source/JavaScriptCore/runtime/Watchdog.cpp:41
>> +    , m_wallClockDeadline(MonotonicTime::infinity())
> 
> This variable doesn't hold wall clock time anymore

Fixed. Even before this patch, it was not wall clock since we used std::chrono::steady_clock.

>> Source/JavaScriptCore/runtime/Watchdog.cpp:135
>> +    auto wallClockTime = MonotonicTime::now();
> 
> Ditto

Fixed.
Comment 5 Yusuke Suzuki 2017-12-26 16:09:11 PST 
Created attachment 330205 [details]
Patch
Comment 6 EWS Watchlist 2017-12-26 16:10:57 PST 
Attachment 330205 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:389:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
Total errors found: 1 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Konstantin Tokarev 2017-12-26 16:22:57 PST 
Comment on attachment 330205 [details]
Patch

r=me

it seems like CLOCK_THREAD_CPUTIME_ID is available on other BSDs too, maybe it makes sense to broaden condition
Comment 8 Yusuke Suzuki 2017-12-26 16:33:17 PST 
Committed r226295: <https://trac.webkit.org/changeset/226295>
Comment 9 Radar WebKit Bug Importer 2018-01-02 12:59:13 PST 
<rdar://problem/36260885>