[JSC] Use uint8_t instead of bool if it is used in JIT
Created attachment 330178 [details] Patch
Comment on attachment 330178 [details] Patch Attachment 330178 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/5826319 New failing tests: imported/w3c/web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/update.https.html
Created attachment 330183 [details] Archive of layout-test-results from ews106 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
The failed test is not related to this patch.
Comment on attachment 330178 [details] Patch Are you building on a system where sizeof(bool) != 1?
(In reply to Alex Christensen from comment #5) > Comment on attachment 330178 [details] > Patch > > Are you building on a system where sizeof(bool) != 1? No. But it is not defined. To avoid difficult bugs, I think we should do either, 1. Changing bool to uint8_t if it is touched from JIT code 2. Add the requirement to WebKit, `static_assert(sizeof(bool) == 1, "")`
(In reply to Yusuke Suzuki from comment #6) > (In reply to Alex Christensen from comment #5) > > Comment on attachment 330178 [details] > > Patch > > > > Are you building on a system where sizeof(bool) != 1? > > No. But it is not defined. To avoid difficult bugs, I think we should do > either, > > 1. Changing bool to uint8_t if it is touched from JIT code > 2. Add the requirement to WebKit, `static_assert(sizeof(bool) == 1, "")` I like (2)
(In reply to Saam Barati from comment #7) > (In reply to Yusuke Suzuki from comment #6) > > (In reply to Alex Christensen from comment #5) > > > Comment on attachment 330178 [details] > > > Patch > > > > > > Are you building on a system where sizeof(bool) != 1? > > > > No. But it is not defined. To avoid difficult bugs, I think we should do > > either, > > > > 1. Changing bool to uint8_t if it is touched from JIT code > > 2. Add the requirement to WebKit, `static_assert(sizeof(bool) == 1, "")` > > I like (2) OK, I'll update the patch.
Created attachment 331862 [details] Patch
Comment on attachment 331862 [details] Patch Clearing flags on attachment: 331862 Committed r227411: <https://trac.webkit.org/changeset/227411>
All reviewed patches have been landed. Closing bug.
<rdar://problem/36774590>