Bug 181143 - [Attachment Support] Don't Blob-convert images and attachments with https:, http: or data: urls
Summary: [Attachment Support] Don't Blob-convert images and attachments with https:, h...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-22 23:24 PST by Wenson Hsieh
Modified: 2018-01-02 16:06 PST (History)
6 users (show)

See Also:

Attachments
Patch (13.83 KB, patch)
2017-12-22 23:35 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Updated bug title (13.83 KB, patch)
2017-12-23 01:11 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2017-12-22 23:24:20 PST 
Don't make attachment elements for images with https:, http: or data: urls. Clients such as Mail would expect pasting or dropping an image with src="https://..." to result in the source URL being preserved (i.e. staying as remote images) instead of creating image attachments out of them.
Comment 1 Radar WebKit Bug Importer 2017-12-22 23:25:07 PST 
<rdar://problem/36200381>
Comment 2 Wenson Hsieh 2017-12-22 23:35:36 PST 
Created attachment 330159 [details]
Patch
Comment 3 Wenson Hsieh 2017-12-23 01:11:20 PST 
Created attachment 330160 [details]
Updated bug title
Comment 4 Wenson Hsieh 2018-01-02 15:46:16 PST 
Comment on attachment 330160 [details]
Updated bug title

Thanks for the review!
Comment 5 WebKit Commit Bot 2018-01-02 16:06:45 PST 
Comment on attachment 330160 [details]
Updated bug title

Clearing flags on attachment: 330160

Committed r226340: <https://trac.webkit.org/changeset/226340>
Comment 6 WebKit Commit Bot 2018-01-02 16:06:46 PST 
All reviewed patches have been landed.  Closing bug.