Bug 181142 - REGRESSION (r225122): fePointLights don't work
Summary: REGRESSION (r225122): fePointLights don't work
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on: 181196
Blocks:
  Show dependency treegraph
 
Reported: 2017-12-22 20:56 PST by Simon Fraser (smfr)
Modified: 2018-01-01 12:33 PST (History)
7 users (show)

See Also:


Attachments
Test case (1.11 KB, text/html)
2017-12-22 20:56 PST, Simon Fraser (smfr)
no flags Details
Patch (6.85 KB, patch)
2017-12-29 08:32 PST, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Patch (8.05 KB, patch)
2017-12-30 21:16 PST, Simon Fraser (smfr)
dbates: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2017-12-22 20:56:33 PST
Created attachment 330157 [details]
Test case

Attached file renders the point light in Chrome and FF, but not in WebKit.
Comment 1 Simon Fraser (smfr) 2017-12-22 21:51:14 PST
Fails in STP 46, works in 17A405
Comment 2 Radar WebKit Bug Importer 2017-12-22 21:51:36 PST
<rdar://problem/36199837>
Comment 3 Simon Fraser (smfr) 2017-12-29 08:32:22 PST
Created attachment 330254 [details]
Patch
Comment 4 EWS Watchlist 2017-12-29 08:33:49 PST
Attachment 330254 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp:45:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/ChangeLog:8:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebCore/ChangeLog:10:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 3 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Simon Fraser (smfr) 2017-12-30 21:16:22 PST
Created attachment 330265 [details]
Patch
Comment 6 Simon Fraser (smfr) 2017-12-30 21:17:10 PST
Patch depends on patch in bug 181196.
Comment 7 Simon Fraser (smfr) 2018-01-01 12:33:14 PST
https://trac.webkit.org/r226317