Bug 181140 - computeTextPaintStyle() does not need to know about frame
Summary: computeTextPaintStyle() does not need to know about frame
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-12-22 14:59 PST by Daniel Bates
Modified: 2017-12-22 15:28 PST (History)
5 users (show)

See Also:


Attachments
Patch (5.37 KB, patch)
2017-12-22 15:05 PST, Daniel Bates
dbates: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2017-12-22 14:59:43 PST
computeTextPaintStyle() should take the viewport size instead of a frame as it is unnecessary for it to know about a frame.
Comment 1 Daniel Bates 2017-12-22 15:05:47 PST
Created attachment 330148 [details]
Patch
Comment 2 Daniel Bates 2017-12-22 15:14:38 PST
Comment on attachment 330148 [details]
Patch

r-, this won't work :( we need the frame to also query for the focus controller and to query the document if it is printing
Comment 3 Daniel Bates 2017-12-22 15:28:17 PST
One way to fix this is to have computeTextPaintStyle() take individual arguments for whether the document is printing, whether we should print backgrounds and whether the page is currently focused. This does not sound like a big improvement.