REGRESSION(r218089): [GTK] webkit_web_view_get_inspector() needs to be called, otherwise inspector does not close

[Cédric Bellegarde]

When enabling inspector with "developer-extras", the inspector window opened from default webkit menu can't be closed.

Adding a webkit_web_view_get_inspector() call fixes the issue. (Was not present in 2.16)

Exemple:
#!/usr/bin/python
from gi.repository import WebKit2
from gi.repository import Gtk

def close(window):
        Gtk.main_quit()

def main():
        Gtk.init()

        view = WebKit2.WebView()
        settings = view.get_settings()
        settings.set_property("enable-developer-extras", True)
        view.load_uri("http://google.fr")
        window = Gtk.Window()
        window.add(view)
        window.connect("destroy", close)
        window.show_all()

        Gtk.main()

main()

[Michael Catanzaro]

This one, I can reproduce. 2.18.3 is fine, trunk is not.

[Michael Catanzaro]

We could probably fix it by calling webkitWebInspectorCreate during WebKitWebView construction, instead of doing it lazily, but there's probably a better way, if we could figure out what changed here.

[Carlos Garcia Campos]

I can't reproduce this.

[Michael Catanzaro]

(In reply to Carlos Garcia Campos from comment #3)
> I can't reproduce this.

Did you try the example in the first comment? MiniBrowser and epiphany both calls webkit_web_view_get_inspector(), which avoids the problem, so you won't be able to reproduce there.

[Carlos Garcia Campos]

I broke this in r218089

[Carlos Garcia Campos]

Created attachment 335176 [details]
Patch

[Adrian Perez]

I can reproduce this with Dinghy (https://github.com/aperezdc/dinghy),
which is is a WPE launcher/browser. It can be built with against
WebKitGTK+ as well passing “-DDY_USE_WEBKITGTK=ON” to CMake. The issue
is present in both ports.

[Carlos Garcia Campos]

Committed r229396: <https://trac.webkit.org/changeset/229396>

[Radar WebKit Bug Importer]

<rdar://problem/38265943>

[Radar WebKit Bug Importer]

<rdar://problem/38265944>