Bug 181114 – REGRESSION(r223678): Cannot copy & paste a web page content into Yahoo! Mail

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Ryosuke Niwa]

* STEPS TO REPRODUCE
1. Launch Safari
2. Navigate to https://mail.yahoo.com/
3. Sign in with valid credentials
4. Click Compose button
5. New Window (⌘N)
6. Navigate to https://1stwebdesigner.com/image-file-types/
7. Copy a combination of text and an image from the new window and paste it into Yahoo’s compose window

* EXPECTED RESULTS
Text and image should be displayed in Yahoo’s compose window

* ACTUAL RESULTS
Text is displayed as expected, but the image is lost

<rdar://problem/35547066>

[Ryosuke Niwa]

Created attachment 330090 [details]
Avoids blob conversion for HTTP/HTTPs

[Ryosuke Niwa]

Created attachment 330095 [details]
Rebaselined the test

[EWS Watchlist]

Comment on attachment 330095 [details]
Rebaselined the test

Attachment 330095 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/5797468

New failing tests:
http/tests/security/clipboard/copy-paste-html-cross-origin-iframe-across-origin.html

[EWS Watchlist]

Created attachment 330103 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[EWS Watchlist]

Comment on attachment 330095 [details]
Rebaselined the test

Attachment 330095 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/5797725

New failing tests:
http/tests/security/clipboard/copy-paste-html-cross-origin-iframe-across-origin.html

[EWS Watchlist]

Created attachment 330104 [details]
Archive of layout-test-results from ews102 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Ryosuke Niwa]

Created attachment 330106 [details]
Added the forgotten test file

[Geoffrey Garen]

Comment on attachment 330106 [details]
Added the forgotten test file

View in context: https://bugs.webkit.org/attachment.cgi?id=330106&action=review

r=me

> Source/WebCore/ChangeLog:12
> +        We've also considered using data URLs instead of blob URLs for conversion but pasing a large image converted into

pasting

> Source/WebCore/ChangeLog:17
> +        cross-origin content, restoring the behavior prior to  For contents converted from attributed strings, we continue to convert to blob URL since

prior to...?

[Ryosuke Niwa]

(In reply to Geoffrey Garen from comment #8)
> Comment on attachment 330106 [details]
> Added the forgotten test file
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=330106&action=review
> 
> r=me
> 
> > Source/WebCore/ChangeLog:12
> > +        We've also considered using data URLs instead of blob URLs for conversion but pasing a large image converted into
> 
> pasting

Fixed.

> > Source/WebCore/ChangeLog:17
> > +        cross-origin content, restoring the behavior prior to  For contents converted from attributed strings, we continue to convert to blob URL since
> 
> prior to...?

Weird. It should have said. "prior to r223678".

[Ryosuke Niwa]

Committed r226272: <https://trac.webkit.org/changeset/226272>

[Radar WebKit Bug Importer]

<rdar://problem/36197320>

[Wenson Hsieh]

Comment on attachment 330106 [details]
Added the forgotten test file

View in context: https://bugs.webkit.org/attachment.cgi?id=330106&action=review

> Source/WebCore/ChangeLog:10
> +        Yahoo! Mail, Gmail, and other major online email services.

I think the attachment element generation codepath would also want to follow these same rules (this would make the Mail folks happy, since they prefer pasted http: and https: image URLs to not become image attachments, but rather stay as remote images). I'll tweak this in a followup...