RESOLVED FIXED 181112
lowering get_by_val to GetById inside bytecode parser should check for BadType exit kind 
https://bugs.webkit.org/show_bug.cgi?id=181112
Summary lowering get_by_val to GetById inside bytecode parser should check for BadTyp...
Saam Barati
Reported 2017-12-21 17:47:53 PST
We do a CheckStringIdent on the string identifier. This may exit for BadType. This leads to an infinite exit loop in Speedometer. Fixing this isn't a speedup, but we should fix it.
Attachments
patch (2.44 KB, patch)
2017-12-21 17:57 PST, Saam Barati 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2017-12-21 17:57:20 PST
Created attachment 330085 [details] patch
Mark Lam
Comment 2 2017-12-21 17:59:12 PST
Comment on attachment 330085 [details] patch r=me
WebKit Commit Bot
Comment 3 2017-12-21 19:05:21 PST
Comment on attachment 330085 [details] patch Clearing flags on attachment: 330085 Committed r226254: <https://trac.webkit.org/changeset/226254>
WebKit Commit Bot
Comment 4 2017-12-21 19:05:23 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2017-12-21 19:06:36 PST
<rdar://problem/36189779>
Note You need to log in before you can comment on or make changes to this bug.