Bug 181112 - lowering get_by_val to GetById inside bytecode parser should check for BadType exit kind
Summary: lowering get_by_val to GetById inside bytecode parser should check for BadTyp...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-21 17:47 PST by Saam Barati
Modified: 2017-12-21 19:06 PST (History)
13 users (show)

See Also:


Attachments
patch (2.44 KB, patch)
2017-12-21 17:57 PST, Saam Barati
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2017-12-21 17:47:53 PST
We do a CheckStringIdent on the string identifier. This may exit for BadType. This leads to an infinite exit loop in Speedometer. Fixing this isn't a speedup, but we should fix it.
Comment 1 Saam Barati 2017-12-21 17:57:20 PST
Created attachment 330085 [details]
patch
Comment 2 Mark Lam 2017-12-21 17:59:12 PST
Comment on attachment 330085 [details]
patch

r=me
Comment 3 WebKit Commit Bot 2017-12-21 19:05:21 PST
Comment on attachment 330085 [details]
patch

Clearing flags on attachment: 330085

Committed r226254: <https://trac.webkit.org/changeset/226254>
Comment 4 WebKit Commit Bot 2017-12-21 19:05:23 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2017-12-21 19:06:36 PST
<rdar://problem/36189779>