RESOLVED FIXED181109
[RenderTreeBuilder] Move RenderButton::addChild() tree mutation to RenderTreeBuilder 
https://bugs.webkit.org/show_bug.cgi?id=181109
Summary [RenderTreeBuilder] Move RenderButton::addChild() tree mutation to RenderTree...
alan
Reported 2017-12-21 16:56:58 PST
ssia
Attachments
Patch (7.17 KB, patch)
2017-12-21 20:08 PST, alan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-12-21 16:58:11 PST
<rdar://problem/36188262>
alan
Comment 2 2017-12-21 20:08:46 PST
Created attachment 330096 [details] Patch
Antti Koivisto
Comment 3 2017-12-22 07:21:20 PST
Comment on attachment 330096 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=330096&action=review > Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:64 > +static RenderBlock& createInnerRendererForButtonIfNeeded(RenderButton& button, RenderTreeBuilder& builder) Maybe RenderTreeBuilder::Forms at some point?
WebKit Commit Bot
Comment 4 2017-12-22 08:28:54 PST
Comment on attachment 330096 [details] Patch Clearing flags on attachment: 330096 Committed r226265: <https://trac.webkit.org/changeset/226265>
WebKit Commit Bot
Comment 5 2017-12-22 08:28:55 PST
All reviewed patches have been landed. Closing bug.
Simon Fraser (smfr)
Comment 6 2017-12-22 09:43:13 PST
Comment on attachment 330096 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=330096&action=review > Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:72 > + button.RenderFlexibleBox::addChild(builder, WTFMove(wrapper)); What is this oddness?
alan
Comment 7 2017-12-22 09:44:15 PST
(In reply to Simon Fraser (smfr) from comment #6) > Comment on attachment 330096 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=330096&action=review > > > Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:72 > > + button.RenderFlexibleBox::addChild(builder, WTFMove(wrapper)); > > What is this oddness? It is to ensure no functionality change at this point.
Note You need to log in before you can comment on or make changes to this bug.