Bug 181109 - [RenderTreeBuilder] Move RenderButton::addChild() tree mutation to RenderTreeBuilder
Summary: [RenderTreeBuilder] Move RenderButton::addChild() tree mutation to RenderTree...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-21 16:56 PST by zalan
Modified: 2017-12-22 09:44 PST (History)
6 users (show)

See Also:


Attachments
Patch (7.17 KB, patch)
2017-12-21 20:08 PST, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2017-12-21 16:56:58 PST
ssia
Comment 1 Radar WebKit Bug Importer 2017-12-21 16:58:11 PST
<rdar://problem/36188262>
Comment 2 zalan 2017-12-21 20:08:46 PST
Created attachment 330096 [details]
Patch
Comment 3 Antti Koivisto 2017-12-22 07:21:20 PST
Comment on attachment 330096 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330096&action=review

> Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:64
> +static RenderBlock& createInnerRendererForButtonIfNeeded(RenderButton& button, RenderTreeBuilder& builder)

Maybe RenderTreeBuilder::Forms at some point?
Comment 4 WebKit Commit Bot 2017-12-22 08:28:54 PST
Comment on attachment 330096 [details]
Patch

Clearing flags on attachment: 330096

Committed r226265: <https://trac.webkit.org/changeset/226265>
Comment 5 WebKit Commit Bot 2017-12-22 08:28:55 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Simon Fraser (smfr) 2017-12-22 09:43:13 PST
Comment on attachment 330096 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330096&action=review

> Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:72
> +    button.RenderFlexibleBox::addChild(builder, WTFMove(wrapper));

What is this oddness?
Comment 7 zalan 2017-12-22 09:44:15 PST
(In reply to Simon Fraser (smfr) from comment #6)
> Comment on attachment 330096 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=330096&action=review
> 
> > Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:72
> > +    button.RenderFlexibleBox::addChild(builder, WTFMove(wrapper));
> 
> What is this oddness?

It is to ensure no functionality change at this point.