RESOLVED FIXED 181104
Minor cleanup in WebContentReaderCocoa after r226213 
https://bugs.webkit.org/show_bug.cgi?id=181104
Summary Minor cleanup in WebContentReaderCocoa after r226213
Ryosuke Niwa
Reported 2017-12-21 14:15:09 PST
Use more early exit to make the logic clear.
Attachments
Cleanup (8.23 KB, patch)
2017-12-21 14:17 PST, Ryosuke Niwa 		wenson_hsieh: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2017-12-21 14:17:12 PST
Created attachment 330067 [details] Cleanup
Wenson Hsieh
Comment 2 2017-12-21 14:22:48 PST
Comment on attachment 330067 [details] Cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=330067&action=review > Source/WebCore/editing/cocoa/WebContentReaderCocoa.mm:345 > +static String markupForFragmentToInDocument(Ref<DocumentFragment>&& fragment, Document& document) Did you mean markupForFragmentInDocument?
Ryosuke Niwa
Comment 3 2017-12-21 14:23:34 PST
(In reply to Wenson Hsieh from comment #2) > Comment on attachment 330067 [details] > Cleanup > > View in context: > https://bugs.webkit.org/attachment.cgi?id=330067&action=review > > > Source/WebCore/editing/cocoa/WebContentReaderCocoa.mm:345 > > +static String markupForFragmentToInDocument(Ref<DocumentFragment>&& fragment, Document& document) > > Did you mean markupForFragmentInDocument? Oops, yes. Will fix.
Ryosuke Niwa
Comment 4 2017-12-21 14:32:16 PST
Committed r226242: <https://trac.webkit.org/changeset/226242>
Radar WebKit Bug Importer
Comment 5 2017-12-21 14:36:07 PST
<rdar://problem/36185686>
Note You need to log in before you can comment on or make changes to this bug.