Bug 181093 - Update Service Workers status to Supported in Preview
Summary: Update Service Workers status to Supported in Preview
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Maciej Stachowiak
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-21 11:29 PST by Maciej Stachowiak
Modified: 2017-12-21 17:05 PST (History)
10 users (show)

See Also:


Attachments
Patch (1.02 KB, patch)
2017-12-21 11:29 PST, Maciej Stachowiak
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews105 for mac-elcapitan-wk2 (2.80 MB, application/zip)
2017-12-21 12:29 PST, EWS Watchlist
no flags Details
Patch for landing (1.02 KB, patch)
2017-12-21 12:39 PST, Maciej Stachowiak
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Stachowiak 2017-12-21 11:29:19 PST
Update Service Workers status to Supported in Preview
Comment 1 Maciej Stachowiak 2017-12-21 11:29:41 PST
Created attachment 330044 [details]
Patch
Comment 2 Maciej Stachowiak 2017-12-21 11:31:01 PST
I think there's other features.json entries that should be updated to "Supported in Preview". Cc Jon Davis to take a look. This one seems to have more interest than others though
Comment 3 Andy Estes 2017-12-21 11:36:18 PST
Comment on attachment 330044 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330044&action=review

> Source/WebCore/features.json:489
> -            "status": "In Development"
> +            "status": "Supported in Preview"

"Supported In Preview" is how it's capitalized elsewhere in this file.
Comment 4 EWS Watchlist 2017-12-21 12:29:00 PST
Comment on attachment 330044 [details]
Patch

Attachment 330044 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/5791185

New failing tests:
fast/mediastream/MediaStream-MediaElement-setObject-null.html
Comment 5 EWS Watchlist 2017-12-21 12:29:01 PST
Created attachment 330051 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 6 Maciej Stachowiak 2017-12-21 12:39:36 PST
Created attachment 330053 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2017-12-21 15:03:33 PST
Comment on attachment 330053 [details]
Patch for landing

Rejecting attachment 330053 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 330053, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
fs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 226242 = bd9803a634bac75c21fe4b0a3cde20360f6dbf44
r226243 = 93c3594a66a5045bde104a19492f6c8043d26557
r226244 = fc241f2f821feab33f4825640918a1b11c89cc1d
r226245 = 0e6d7873efdebf054aa895adacc19ad10454ad47
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: http://webkit-queues.webkit.org/results/5793603
Comment 8 Alexey Proskuryakov 2017-12-21 16:43:29 PST
Comment on attachment 330053 [details]
Patch for landing

Not sure what this means, trying again. Git.
Comment 9 WebKit Commit Bot 2017-12-21 17:04:00 PST
Comment on attachment 330053 [details]
Patch for landing

Clearing flags on attachment: 330053

Committed r226250: <https://trac.webkit.org/changeset/226250>
Comment 10 WebKit Commit Bot 2017-12-21 17:04:02 PST
All reviewed patches have been landed.  Closing bug.
Comment 11 Radar WebKit Bug Importer 2017-12-21 17:05:27 PST
<rdar://problem/36188369>