Bug 18109 - Implement hanging punctuation
: Implement hanging punctuation
Status: ASSIGNED
Product: WebKit
Classification: Unclassified
Component: CSS
: 528+ (Nightly build)
: Macintosh OS X 10.5
: P2 Normal
Assigned To: Dave Hyatt
:
Depends on: 104996
Blocks:
  Show dependency treegraph
 
Reported: 2008-03-26 03:49 PDT by Nicholas Shanks
Modified: 2016-06-22 20:35 PDT (History)
9 users (show)

See Also:


Attachments
Patch (19.86 KB, patch)
2016-02-03 12:10 PST, Dave Hyatt
no flags Details | Formatted Diff | Diff
Patch (19.78 KB, patch)
2016-02-03 12:14 PST, Dave Hyatt
zalan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nicholas Shanks 2008-03-26 03:49:37 PDT
The css3-text module is going nowhere fast, and it's hanging-punctuation declaration is so ill-defined that I can't even figure out what the values mean.

Since WebKit is the typographical tiger of the web world, we should come up with something awesome that works for all scripts and locales, which we can submit to the CSS WG.
Comment 1 Dave Hyatt 2008-03-27 13:56:16 PDT
Agree 100%.  I've wanted this feature for a while (even if it's just opt-in through a new property).
Comment 2 Daniel 2010-08-23 06:55:37 PDT
Any news on this? I checked W3C's specifications and it seems like they don't know how to implement it in a code either. But this would be so useful for any web designer, since, let's admit it, punctuation within the content box at the start of a paragraph really does suck. We need Webkit to lead the way on this, as you guys often do! :)

Just wanted to bring this up since the last post on this feature request goes back to 2008.
Comment 3 Dave Hyatt 2016-02-03 12:10:09 PST
Created attachment 270594 [details]
Patch
Comment 4 WebKit Commit Bot 2016-02-03 12:11:32 PST
Attachment 270594 [details] did not pass style-queue:


ERROR: Source/WebCore/css/CSSPrimitiveValueMappings.h:1634:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
ERROR: Source/WebCore/css/CSSParser.cpp:10536:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
Total errors found: 2 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Dave Hyatt 2016-02-03 12:14:19 PST
Created attachment 270595 [details]
Patch
Comment 6 Dave Hyatt 2016-02-03 12:54:49 PST
Initial parsing landed in r196075.