Bug 181077 - DeferredLoadingScope incorrectly disabled images or enables deferred loading
Summary: DeferredLoadingScope incorrectly disabled images or enables deferred loading
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-20 21:22 PST by Ryosuke Niwa
Modified: 2017-12-20 22:50 PST (History)
2 users (show)

See Also:

Attachments
Fixes the bug (6.83 KB, patch)
2017-12-20 21:24 PST, Ryosuke Niwa 		wenson_hsieh: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2017-12-20 21:22:47 PST 
DeferredLoadingScope incorrectly disabled images or enables deferred loading
Comment 1 Ryosuke Niwa 2017-12-20 21:24:30 PST 
Created attachment 330005 [details]
Fixes the bug
Comment 2 Wenson Hsieh 2017-12-20 22:06:24 PST 
Comment on attachment 330005 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=330005&action=review

> LayoutTests/editing/pasteboard/pasting-with-images-disabled-should-not-enable-deferred-loading.html:14
> +    imageLoaded = false;

Let's remove this before landing (...unless it's a special global flag used by one of the test harness scripts?)

> LayoutTests/editing/pasteboard/pasting-with-images-disabled-should-not-enable-deferred-loading.html:16
> +    setTimeout(() => finishJSTest(), 1000);

Let's remove this too.
Comment 3 Ryosuke Niwa 2017-12-20 22:09:39 PST 
(In reply to Wenson Hsieh from comment #2)
> Comment on attachment 330005 [details]
> Fixes the bug
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=330005&action=review
> 
> > LayoutTests/editing/pasteboard/pasting-with-images-disabled-should-not-enable-deferred-loading.html:14
> > +    imageLoaded = false;
> 
> Let's remove this before landing (...unless it's a special global flag used
> by one of the test harness scripts?)

Oops, yeah, this was a debugging code. Removed.
 
> > LayoutTests/editing/pasteboard/pasting-with-images-disabled-should-not-enable-deferred-loading.html:16
> > +    setTimeout(() => finishJSTest(), 1000);
> 
> Let's remove this too.

Ditto.

Thanks for the review.
Comment 4 Ryosuke Niwa 2017-12-20 22:48:50 PST 
Committed r226216: <https://trac.webkit.org/changeset/226216>
Comment 5 Radar WebKit Bug Importer 2017-12-20 22:50:39 PST 
<rdar://problem/36172298>