Bug 181077 – DeferredLoadingScope incorrectly disabled images or enables deferred loading

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Ryosuke Niwa]

DeferredLoadingScope incorrectly disabled images or enables deferred loading

[Ryosuke Niwa]

Created attachment 330005 [details]
Fixes the bug

[Wenson Hsieh]

Comment on attachment 330005 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=330005&action=review

> LayoutTests/editing/pasteboard/pasting-with-images-disabled-should-not-enable-deferred-loading.html:14
> +    imageLoaded = false;

Let's remove this before landing (...unless it's a special global flag used by one of the test harness scripts?)

> LayoutTests/editing/pasteboard/pasting-with-images-disabled-should-not-enable-deferred-loading.html:16
> +    setTimeout(() => finishJSTest(), 1000);

Let's remove this too.

[Ryosuke Niwa]

(In reply to Wenson Hsieh from comment #2)
> Comment on attachment 330005 [details]
> Fixes the bug
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=330005&action=review
> 
> > LayoutTests/editing/pasteboard/pasting-with-images-disabled-should-not-enable-deferred-loading.html:14
> > +    imageLoaded = false;
> 
> Let's remove this before landing (...unless it's a special global flag used
> by one of the test harness scripts?)

Oops, yeah, this was a debugging code. Removed.
 
> > LayoutTests/editing/pasteboard/pasting-with-images-disabled-should-not-enable-deferred-loading.html:16
> > +    setTimeout(() => finishJSTest(), 1000);
> 
> Let's remove this too.

Ditto.

Thanks for the review.

[Ryosuke Niwa]

Committed r226216: <https://trac.webkit.org/changeset/226216>

[Radar WebKit Bug Importer]

<rdar://problem/36172298>