RESOLVED FIXED 181074
Clean up context menu code 
https://bugs.webkit.org/show_bug.cgi?id=181074
Summary Clean up context menu code
Alex Christensen
Reported 2017-12-20 19:00:45 PST
Clean up context menu code
Attachments
Patch (26.50 KB, patch)
2017-12-20 19:02 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (31.89 KB, patch)
2017-12-20 19:31 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (32.60 KB, patch)
2017-12-20 20:42 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (32.89 KB, patch)
2017-12-20 20:48 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (33.50 KB, patch)
2017-12-20 21:16 PST, Alex Christensen 		bfulgham: review+
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2017-12-20 19:02:53 PST
Created attachment 329993 [details] Patch
EWS Watchlist
Comment 2 2017-12-20 19:04:24 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Alex Christensen
Comment 3 2017-12-20 19:31:43 PST
Created attachment 329997 [details] Patch
Alex Christensen
Comment 4 2017-12-20 20:42:48 PST
Created attachment 330001 [details] Patch
Alex Christensen
Comment 5 2017-12-20 20:48:08 PST
Created attachment 330002 [details] Patch
Alex Christensen
Comment 6 2017-12-20 21:16:05 PST
Created attachment 330004 [details] Patch
Brent Fulgham
Comment 7 2017-12-28 14:01:34 PST
Comment on attachment 330004 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=330004&action=review Nice cleanup! r=me. > Source/WebKit/ChangeLog:10 > + Remove dead iOS code. Reduce allocations. Add stub for WPE. Yay! > Source/WebKit/UIProcess/WebPageProxy.cpp:4732 > + m_activeContextMenu = m_pageClient.createContextMenuProxy(*this, WTFMove(contextMenuContextData), userData); Is it okay to move 'contextMenuContextData' here, after also assigning it above? I guess the assignment is copying, so never mind.
Alex Christensen
Comment 8 2018-01-02 09:17:31 PST
http://trac.webkit.org/r226323
Radar WebKit Bug Importer
Comment 9 2018-01-02 12:58:04 PST
<rdar://problem/36260857>
Note You need to log in before you can comment on or make changes to this bug.