Bug 181074 - Clean up context menu code
Summary: Clean up context menu code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-20 19:00 PST by Alex Christensen
Modified: 2018-01-02 12:58 PST (History)
7 users (show)

See Also:


Attachments
Patch (26.50 KB, patch)
2017-12-20 19:02 PST, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (31.89 KB, patch)
2017-12-20 19:31 PST, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (32.60 KB, patch)
2017-12-20 20:42 PST, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (32.89 KB, patch)
2017-12-20 20:48 PST, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (33.50 KB, patch)
2017-12-20 21:16 PST, Alex Christensen
bfulgham: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2017-12-20 19:00:45 PST
Clean up context menu code
Comment 1 Alex Christensen 2017-12-20 19:02:53 PST
Created attachment 329993 [details]
Patch
Comment 2 EWS Watchlist 2017-12-20 19:04:24 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Alex Christensen 2017-12-20 19:31:43 PST
Created attachment 329997 [details]
Patch
Comment 4 Alex Christensen 2017-12-20 20:42:48 PST
Created attachment 330001 [details]
Patch
Comment 5 Alex Christensen 2017-12-20 20:48:08 PST
Created attachment 330002 [details]
Patch
Comment 6 Alex Christensen 2017-12-20 21:16:05 PST
Created attachment 330004 [details]
Patch
Comment 7 Brent Fulgham 2017-12-28 14:01:34 PST
Comment on attachment 330004 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330004&action=review

Nice cleanup! r=me.

> Source/WebKit/ChangeLog:10
> +        Remove dead iOS code.  Reduce allocations.  Add stub for WPE.

Yay!

> Source/WebKit/UIProcess/WebPageProxy.cpp:4732
> +    m_activeContextMenu = m_pageClient.createContextMenuProxy(*this, WTFMove(contextMenuContextData), userData);

Is it okay to move 'contextMenuContextData' here, after also assigning it above? I guess the assignment is copying, so never mind.
Comment 8 Alex Christensen 2018-01-02 09:17:31 PST
http://trac.webkit.org/r226323
Comment 9 Radar WebKit Bug Importer 2018-01-02 12:58:04 PST
<rdar://problem/36260857>