Add media stream screen capture IDL and stub functions
<rdar://problem/36168724>
Created attachment 329979 [details] Patch
Comment on attachment 329979 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=329979&action=review > Source/WebCore/page/RuntimeEnabledFeatures.h:270 > + bool m_isScreenCaptureEnabled {false }; s/{false/{ false/ > Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp:323 > + case CaptureDevice::DeviceType::Browser: I was expecting one ScreenCapture DeviceType. What is the benefit of bringing these in finer grained types? > LayoutTests/fast/mediastream/screencapture-disabled-expected.txt:1 > +PASS undefined is undefined. strange message but I guess it is fine.
Comment on attachment 329979 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=329979&action=review >> Source/WebCore/page/RuntimeEnabledFeatures.h:270 >> + bool m_isScreenCaptureEnabled {false }; > > s/{false/{ false/ Oops, will fix. >> Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp:323 >> + case CaptureDevice::DeviceType::Browser: > > I was expecting one ScreenCapture DeviceType. > What is the benefit of bringing these in finer grained types? A port may not support all types of screen capture, so WebKit will need to signal the UA so it can prompt the user with only the supported types. Further, once the user chooses a screen, application, window, or tab to share, the UA will have to pass the ID of the "display surface" as well as the type.
Created attachment 329984 [details] Patch
Comment on attachment 329984 [details] Patch Clearing flags on attachment: 329984 Committed r226211: <https://trac.webkit.org/changeset/226211>
All reviewed patches have been landed. Closing bug.
Comment on attachment 329984 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=329984&action=review > Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h:107 > +@property (nonatomic, setter=_setScreenCaptureEnabled:) BOOL _screenCaptureEnabled WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_MAC_TBA)); For the record, this should have been ios(WK_IOS_TBA). I landed https://trac.webkit.org/changeset/226513 to fix the iOS build with the public SDK.
(In reply to Frédéric Wang (:fredw) from comment #8) > Comment on attachment 329984 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=329984&action=review > > > Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h:107 > > +@property (nonatomic, setter=_setScreenCaptureEnabled:) BOOL _screenCaptureEnabled WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_MAC_TBA)); > > For the record, this should have been ios(WK_IOS_TBA). > > I landed > > https://trac.webkit.org/changeset/226513 > > to fix the iOS build with the public SDK. Thanks Frédéric!