WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
181070
[MediaStream] Add screen capture IDL and stub functions
https://bugs.webkit.org/show_bug.cgi?id=181070
Summary
[MediaStream] Add screen capture IDL and stub functions
Eric Carlson
Reported
2017-12-20 17:28:53 PST
Add media stream screen capture IDL and stub functions
Attachments
Patch
(44.65 KB, patch)
2017-12-20 17:42 PST
,
Eric Carlson
no flags
Details
Formatted Diff
Diff
Patch
(44.84 KB, patch)
2017-12-20 18:12 PST
,
Eric Carlson
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2017-12-20 17:31:00 PST
<
rdar://problem/36168724
>
Eric Carlson
Comment 2
2017-12-20 17:42:57 PST
Created
attachment 329979
[details]
Patch
youenn fablet
Comment 3
2017-12-20 17:54:50 PST
Comment on
attachment 329979
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=329979&action=review
> Source/WebCore/page/RuntimeEnabledFeatures.h:270 > + bool m_isScreenCaptureEnabled {false };
s/{false/{ false/
> Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp:323 > + case CaptureDevice::DeviceType::Browser:
I was expecting one ScreenCapture DeviceType. What is the benefit of bringing these in finer grained types?
> LayoutTests/fast/mediastream/screencapture-disabled-expected.txt:1 > +PASS undefined is undefined.
strange message but I guess it is fine.
Eric Carlson
Comment 4
2017-12-20 18:04:05 PST
Comment on
attachment 329979
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=329979&action=review
>> Source/WebCore/page/RuntimeEnabledFeatures.h:270 >> + bool m_isScreenCaptureEnabled {false }; > > s/{false/{ false/
Oops, will fix.
>> Source/WebCore/platform/mediastream/RealtimeMediaSourceCenter.cpp:323 >> + case CaptureDevice::DeviceType::Browser: > > I was expecting one ScreenCapture DeviceType. > What is the benefit of bringing these in finer grained types?
A port may not support all types of screen capture, so WebKit will need to signal the UA so it can prompt the user with only the supported types. Further, once the user chooses a screen, application, window, or tab to share, the UA will have to pass the ID of the "display surface" as well as the type.
Eric Carlson
Comment 5
2017-12-20 18:12:50 PST
Created
attachment 329984
[details]
Patch
WebKit Commit Bot
Comment 6
2017-12-20 18:45:40 PST
Comment on
attachment 329984
[details]
Patch Clearing flags on attachment: 329984 Committed
r226211
: <
https://trac.webkit.org/changeset/226211
>
WebKit Commit Bot
Comment 7
2017-12-20 18:45:41 PST
All reviewed patches have been landed. Closing bug.
Frédéric Wang (:fredw)
Comment 8
2018-01-08 08:15:35 PST
Comment on
attachment 329984
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=329984&action=review
> Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h:107 > +@property (nonatomic, setter=_setScreenCaptureEnabled:) BOOL _screenCaptureEnabled WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_MAC_TBA));
For the record, this should have been ios(WK_IOS_TBA). I landed
https://trac.webkit.org/changeset/226513
to fix the iOS build with the public SDK.
Eric Carlson
Comment 9
2018-01-08 10:30:53 PST
(In reply to Frédéric Wang (:fredw) from
comment #8
)
> Comment on
attachment 329984
[details]
> Patch > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=329984&action=review
> > > Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h:107 > > +@property (nonatomic, setter=_setScreenCaptureEnabled:) BOOL _screenCaptureEnabled WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_MAC_TBA)); > > For the record, this should have been ios(WK_IOS_TBA). > > I landed > >
https://trac.webkit.org/changeset/226513
> > to fix the iOS build with the public SDK.
Thanks Frédéric!
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug