Bug 181068 - [Attachment Support] Attachment replacement logic should not depend on subresource URL attribute replacement
Summary: [Attachment Support] Attachment replacement logic should not depend on subres...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-20 16:58 PST by Wenson Hsieh
Modified: 2017-12-20 19:50 PST (History)
5 users (show)

See Also:

Attachments
First pass (23.39 KB, patch)
2017-12-20 17:26 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Minor adjustments. (22.98 KB, patch)
2017-12-20 17:32 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2017-12-20 16:58:19 PST 
Currently, we always replace subresource URLs with blob URLs when reading web content. We want to revert this policy; however, logic to replace DOM elements in the rich fragment with attachments currently depends on us always replacing subresources with blobs. This means we need to decouple logic for replacing attachments from logic that replaces resource URLs in element attributes with blob URLs.
Comment 1 Radar WebKit Bug Importer 2017-12-20 17:10:20 PST 
<rdar://problem/36168313>
Comment 2 Wenson Hsieh 2017-12-20 17:26:47 PST 
Created attachment 329972 [details]
First pass
Comment 3 Wenson Hsieh 2017-12-20 17:32:47 PST 
Created attachment 329975 [details]
Minor adjustments.
Comment 4 Ryosuke Niwa 2017-12-20 19:32:23 PST 
Comment on attachment 329975 [details]
Minor adjustments.

r=me. Thanks for the refactoring!
Comment 5 WebKit Commit Bot 2017-12-20 19:50:20 PST 
Comment on attachment 329975 [details]
Minor adjustments.

Clearing flags on attachment: 329975

Committed r226213: <https://trac.webkit.org/changeset/226213>
Comment 6 WebKit Commit Bot 2017-12-20 19:50:21 PST 
All reviewed patches have been landed.  Closing bug.