Bug 181055 - webkitpy: simctl cannot handle partial runtime version matches
Summary: webkitpy: simctl cannot handle partial runtime version matches
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-20 14:00 PST by Jonathan Bedard
Modified: 2017-12-20 20:38 PST (History)
8 users (show)

See Also:

Attachments
Patch (1.68 KB, patch)
2017-12-20 14:16 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (4.34 KB, patch)
2017-12-20 15:59 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2017-12-20 14:00:17 PST 
simctl should be able to handle partial runtime version matches.  For example, a runtime for iOS 11.0.1 should match a request for an iOS 11 runtime.
Comment 1 Radar WebKit Bug Importer 2017-12-20 14:00:46 PST 
<rdar://problem/36163798>
Comment 2 Jonathan Bedard 2017-12-20 14:16:28 PST 
Created attachment 329953 [details]
Patch
Comment 3 Keith Rollin 2017-12-20 14:47:12 PST 
WFM
Comment 4 Alexey Proskuryakov 2017-12-20 15:43:17 PST 
Comment on attachment 329953 [details]
Patch

It seems worth having some regression tests (both positive and negative matches).
Comment 5 Jonathan Bedard 2017-12-20 15:45:02 PST 
(In reply to Alexey Proskuryakov from comment #4)
> Comment on attachment 329953 [details]
> Patch
> 
> It seems worth having some regression tests (both positive and negative
> matches).

I will add some tests.  Generally, this behavior is already pretty well tested in webkitpy/common/version_unittest.py.
Comment 6 Jonathan Bedard 2017-12-20 15:59:15 PST 
Created attachment 329961 [details]
Patch
Comment 7 WebKit Commit Bot 2017-12-20 20:37:58 PST 
Comment on attachment 329961 [details]
Patch

Clearing flags on attachment: 329961

Committed r226214: <https://trac.webkit.org/changeset/226214>
Comment 8 WebKit Commit Bot 2017-12-20 20:38:00 PST 
All reviewed patches have been landed.  Closing bug.