Bug 181046 - stderr and _IONBF used without including stdio.h
Summary: stderr and _IONBF used without including stdio.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: bmalloc (show other bugs)
Version: WebKit Local Build
Hardware: All Other
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-20 10:42 PST by Ting-Wei Lan
Modified: 2017-12-20 17:11 PST (History)
4 users (show)

See Also:

Attachments
Patch (1008 bytes, patch)
2017-12-20 10:43 PST, Ting-Wei Lan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ting-Wei Lan 2017-12-20 10:42:18 PST 
This causes compilation error on FreeBSD:

FAILED: Source/bmalloc/CMakeFiles/bmalloc.dir/bmalloc/IsoTLS.cpp.o 
/usr/bin/clang++  -DBUILDING_GTK__=1 -DBUILDING_WITH_CMAKE=1 -DBUILDING_bmalloc -DDATA_DIR=\"share\" -DGETTEXT_PACKAGE=\"WebKit2GTK-4.0\" -DHAVE_CONFIG_H=1 -DWEBKITGTK_API_VERSION_STRING=\"4.0\" -I../../Source/bmalloc -fdiagnostics-color=always -fcolor-diagnostics -Wno-parentheses-equality -Qunused-arguments -Wwrite-strings -Wundef -Wpointer-arith -Wmissing-format-attribute -Wformat-security -Wcast-align -Wextra -Wall -march=corei7 -B/home/lantw44/.local/bin -pipe -O3 -fno-strict-aliasing -fno-exceptions -std=c++14 -fno-rtti -O3 -DNDEBUG -fPIC -MD -MT Source/bmalloc/CMakeFiles/bmalloc.dir/bmalloc/IsoTLS.cpp.o -MF Source/bmalloc/CMakeFiles/bmalloc.dir/bmalloc/IsoTLS.cpp.o.d -o Source/bmalloc/CMakeFiles/bmalloc.dir/bmalloc/IsoTLS.cpp.o -c ../../Source/bmalloc/bmalloc/IsoTLS.cpp
../../Source/bmalloc/bmalloc/IsoTLS.cpp:63:21: error: use of undeclared identifier 'stderr'
            setvbuf(stderr, NULL, _IONBF, 0);
                    ^
../../Source/bmalloc/bmalloc/IsoTLS.cpp:63:35: error: use of undeclared identifier '_IONBF'
            setvbuf(stderr, NULL, _IONBF, 0);
                                  ^
2 errors generated.
Comment 1 Ting-Wei Lan 2017-12-20 10:43:39 PST 
Created attachment 329934 [details]
Patch
Comment 2 WebKit Commit Bot 2017-12-20 17:07:53 PST 
Comment on attachment 329934 [details]
Patch

Clearing flags on attachment: 329934

Committed r226204: <https://trac.webkit.org/changeset/226204>
Comment 3 WebKit Commit Bot 2017-12-20 17:07:54 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2017-12-20 17:11:03 PST 
<rdar://problem/36168329>